Repository navigation
fix: per metrics view filter params override the legacy singular f param - #9987
Merged
Merged
Conversation
…param The unified filter bar merged the legacy singular `f` param with the per metrics view `f.<mv>` params. A dimension filtered with different values in the two forms was flagged as an advanced filter and both conditions were ANDed, which matches nothing. Embedded canvas dashboards hit this when the host passes `f=` and the viewer has since edited the filter. A metrics view that has its own param now keeps it; the singular param only seeds the metrics views without one, matching the pre-refactor behaviour.
AdityaHegde
approved these changes
Oct 5, 2026
nishantmonu51
added a commit
that referenced
this pull request
Oct 6, 2026
…param (#9987) * fix: per metrics view filter params override the legacy singular `f` param The unified filter bar merged the legacy singular `f` param with the per metrics view `f.<mv>` params. A dimension filtered with different values in the two forms was flagged as an advanced filter and both conditions were ANDed, which matches nothing. Embedded canvas dashboards hit this when the host passes `f=` and the viewer has since edited the filter. A metrics view that has its own param now keeps it; the singular param only seeds the metrics views without one, matching the pre-refactor behaviour. * Normalize params in the tracker instead of the manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fparam and a per metrics viewf.<mv>param filter the same dimension with different values, the merge flags the filter as advanced and ANDs both conditions, so the canvas shows a read onlyAdvanced (BETA) BD_Lead IN ('A') AND BD_Lead IN ('B')pill and every component reports zero.normalizeParamsnow keeps a metrics view's ownf.<mv>param and only fills in the singularffor metrics views that lack one, andsetUrlParamsmerges the normalized params. This matches the pre-refactor canvas behaviour, which readf.<mv>and fell back tofonly when it was absent.Steps to reproduce
f=<dim> IN ('A')on the iframe URL.B. The URL now carriesf.<mv1>andf.<mv2>.f=<dim> IN ('A')to the URL alongside them, for example by restoring saved state onto the original iframe URL.Advanced (BETA)pill with<dim> IN ('B') AND <dim> IN ('A')per metrics view, and all components show zero. After: a single<dim>chip set toB.Checklist: