[v0.2] Add lazy import to fix circular import and ray init config support#236
Merged
jeffreysijuntan merged 1 commit intoOct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges two issues encountered when testing the
examples/math_tools/train_math_with_tool.shscript.Circular import issue between
engineandworkflowsmodulesPrevious cycling pattern:
workflows/__init__.py → workflows/workflow.py → engine/rollout/rollout_engine.py → engine/__init__.py → engine/agent_workflow_engine.py → workflows/workflow.py ← CYCLE!Improves Ray initialization (
ray.init) configuration to allow more arguments other thannum_cpus.Now it's easier to specify arguments like (
_temp_dir,address,logging_level) under theray_initfields.Changes Made
AgentWorkflowEngineinengine/__init__.pyusing__getattr__()pattern (similar toworkflows/__init__.py.agent_trainer.pybefore passing config toray.init()Motivation
The circular import prevented the engine module from being imported successfully, causing the training to fail on initialization. The ray configuration improvements allow users to properly configure Ray's temporary directory and other settings through Hydra configuration.
Testing
tests/agents/test_math_agent.py)examples/math_tools/train_math_with_tool.sh) with multi-GPU training setup_temp_dir)