Support custom metric for SDK#362
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom metrics in the SDK by allowing agent functions to return metrics alongside their output. The implementation enables agents to return a tuple of (payload, metrics) where the payload can be either a float/int/bool reward or a list of TrajectoryView objects.
Key changes:
- Added tuple output handling in
process_task_with_retryto extract custom metrics from agent responses - Modified
_execute_tasksto merge custom metrics with standard system metrics - Removed debug print statement for rollout correction metrics
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rllm/engine/agent_sdk_engine.py | Added tuple unpacking logic to support custom metrics from agent functions and merge them with system-generated metrics |
| rllm/trainer/verl/agent_sdk_trainer.py | Removed debug print statement for rollout correction metrics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.