Skip to content

[Experimental] Fixing Tinker rollout prompt ids#390

Merged
listar2000 merged 2 commits into
mainfrom
tinker-unified-fix
Feb 7, 2026
Merged

[Experimental] Fixing Tinker rollout prompt ids#390
listar2000 merged 2 commits into
mainfrom
tinker-unified-fix

Conversation

@listar2000
Copy link
Copy Markdown
Collaborator

What does this PR do?

It does the following fixes to the experimental/rollout/tinker_engine:

  • Make sure that the EncodedTextChunk is flattened to list[int] so that the prompt_ids in ModelOutput will consist of either int or ImageChunk (when using Tinker.renderer to tokenize messages).
  • We also change the common visualization code to skip any non-integer element in prompt_ids.

Additionally, it also adds a few features to the experimental/rollout/completer (a wrapper feature on top of rollout_engine that directly returns Step):

  • Add a reset() method to all completers.
  • Add a counter to return prefix (accumulation) metrics for the TITOCompleter.

All the changes above are targetting experimental features. So these changes are non-breaking.

@listar2000 listar2000 merged commit 7d41b25 into main Feb 7, 2026
1 check passed
@listar2000 listar2000 deleted the tinker-unified-fix branch February 7, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant