Fix ChatTemplateParser import in SFT trainer#428
Merged
Conversation
Use rllm's own ChatTemplateParser instead of the non-existent verl.utils.parser module. This aligns with every other file in the codebase which imports from rllm.parser. Fixes #426 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ModuleNotFoundError: No module named 'verl.utils.parser'when using the SFT trainer (#426). The import pointed to a non-existent verl module instead of rllm's ownChatTemplateParser.Type of change
What changed
sft_dataset.pyto importChatTemplateParserfromrllm.parserinstead ofverl.utils.parser.chat_template_parserrllm.parser)get_parser(),parse()withis_first_msgandadd_generation_promptparams)Validation
pre-commit run --all-filesValidation details:
ChatTemplateParserhas identical API surface:get_parser(tokenizer)factory method andparse(messages, add_generation_prompt, is_first_msg)signatureBreaking changes / migration notes
Docs / examples
Related issues / PRs
Screenshots / logs
N/A