Add a schema-level hook for lazy/batched resolution - #1784
Merged
Conversation
Contributor
|
👍 Just as an idea, here is how I personally imagine API could look like: class PostType < GraphQL::Schema::Object
field :id, ID, null: false
field :comments, [CommentType], null: true, lazy: true
# ^
# an explicit flag, no more matching by predefined classes to detect lazy objects
# duck typing, yay!
end
class Schema < GraphQL::Schema
query QueryType
def lazy_resolve(value) # or any other new API method with a default implementation, can be overridden
case value
when MyBatchClass
value.sync # existing behavior, sort of
else
value.resolve_all if value.quacks? # custom behavior if necessary
end
end
end
|
Owner
Author
|
@exAspArk , I think the difference between the code on this branch is the addition of I don't think I want to add field-level opting in, because we have various execution wrappers that may or may not wrap eager values in lazy objects. So, it can be hard to know which fields return lazy values under which conditions! |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL-Ruby's lazy-resolve system is OK, but it has a high overhead without much benefit from its generality. Most of the time, a schema has only one type of lazy object (batch-loader or graphql-batch), and the rest of the time, all the method lookup stuff is overcomplicated and a waste of time.
So, what if we exposed some schema-level methods that could be overridden as needed? In fact, we've already done this in GitHub as a performance consideration (we overrode
#lazy_method_name).TODO:
cc @exAspArk