Repository navigation
feat: add minPitch support for MapView component - #4190
Merged
Merged
Conversation
kevindice
had a problem deploying
to
CI with Mapbox Tokens
April 2, 2026 23:11 — with
GitHub Actions
Failure
kevindice
had a problem deploying
to
CI with Mapbox Tokens
April 2, 2026 23:11 — with
GitHub Actions
Failure
kevindice
had a problem deploying
to
CI with Mapbox Tokens
April 2, 2026 23:11 — with
GitHub Actions
Failure
# Conflicts: # android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kt
…cleared Pass minPitch through the iOS Fabric component view, forward a removed minPitch/maxPitch as nil, and reset the camera bound to the SDK default (0 / 85 degrees) instead of keeping the previous limit.
Contributor
|
Thanks for this! I merged main and pushed a small follow-up: |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
minPitchtoMapView, mirroringmaxPitch, via the SDK camera bounds options on iOS and Android. Use case: a ski area map with 3D terrain that shouldn't tilt below a given angle.Also fixes clearing either limit: removing
minPitch/maxPitchused to leave the previous limit in force (andmaxPitchon iOS was never forwarded as removed). A cleared limit now resets to the SDK default (0° / 85°).minPitchis also wired through the iOS Fabric component view, without which it had no effect on iOS.Tested with the component below (
setCamerato pitch 0/89 after each prop change):Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Component to reproduce the issue you're fixing