Repository navigation
Enable choosing to build shared or static library - #3
Merged
Merged
Conversation
peterNordin
commented
May 1, 2022
| #else | ||
| // TODO Maybe use dllimport | ||
| #define FMI4C_DLLAPI | ||
| #define FMI4C_DLLAPI __declspec(dllimport) |
Collaborator
Author
There was a problem hiding this comment.
I am not sure if dllimport is actually needed. It might be possible to leave this macro blank for both the static and dllimport case. Then the consumer would not need to define FMI4C_STATIC when a static library is used.
peterNordin
force-pushed
the
enable_static_lib
branch
from
May 4, 2022 18:28
69ffd96 to
73cb2f8
Compare
peterNordin
force-pushed
the
enable_static_lib
branch
from
May 4, 2022 19:40
73cb2f8 to
9571d54
Compare
slitvinov
added a commit
to slitvinov/fmi4c
that referenced
this pull request
May 2, 2026
Without this, test FMUs are written to binaries/linux64 (FMI 1/2) or binaries/x86_64-linux (FMI 3) on macOS, while the patched fmi4c reader correctly looks under binaries/darwin64 / aarch64-darwin. With this commit and the reader fix applied, all 6 ctest cases pass on macOS 26.4.1 arm64 (Apple M5): Test #1: fmi1cs ........... Passed 1.05 sec Test robbr48#2: fmi1me ........... Passed 0.36 sec Test robbr48#3: fmi2cs ........... Passed 0.44 sec Test robbr48#4: fmi2me ........... Passed 0.46 sec Test robbr48#5: fmi3cs ........... Passed 0.42 sec Test robbr48#6: fmi3me ........... Passed 0.33 sec 100% tests passed, 0 tests failed out of 6
robbr48
pushed a commit
that referenced
this pull request
May 20, 2026
Without this, test FMUs are written to binaries/linux64 (FMI 1/2) or binaries/x86_64-linux (FMI 3) on macOS, while the patched fmi4c reader correctly looks under binaries/darwin64 / aarch64-darwin. With this commit and the reader fix applied, all 6 ctest cases pass on macOS 26.4.1 arm64 (Apple M5): Test #1: fmi1cs ........... Passed 1.05 sec Test #2: fmi1me ........... Passed 0.36 sec Test #3: fmi2cs ........... Passed 0.44 sec Test #4: fmi2me ........... Passed 0.46 sec Test #5: fmi3cs ........... Passed 0.42 sec Test #6: fmi3me ........... Passed 0.33 sec 100% tests passed, 0 tests failed out of 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable building as static library, default is still shared
When building static library on Windows, and consuming this library FMI4C_STATIC must be defined to avoid assumption of dllimport
Possibly this could be switched around, so that static is the default and that the consumer would have to define some other macro for dllimport.