<RollbarContext /> implementation doesn't match docs

Docs: https://docs.rollbar.com/docs/react#rollbarcontext-component

1 - RollbarContext requires the onRender prop

Calling

<RollbarContext context="home">…</RollbarContext>

doesn't actually set Rollbar's context to 'home'. On further examination of the RollbarContext component, I saw I needed to add a onRender prop for it to work:

<RollbarContext context="home" onRender>…</RollbarContext>

This doesn't align with the docs linked above.

2 - RollbarContext type is incorrect

Given the requirement of the onRender prop, RollbarContext's type is incomplete.

I also have errors using <RollbarContext context="something"> with "react-router-dom": "6.11.2":

import { useRoutes } from 'react-router-dom';

return useRoutes([
{
  path: `${Route.Foo}/:bar`,
  element: (
    <RollbarContext context="/foo-bar">
      <FooBar />
    </RollbarContext>
  )
}
]);

cc @rollbar-bborsits (Juanjo Marrón suggested to ping you) to have a look at this 🙏

@waltjones

cc @waltjones

Fix RollbarContext without a payload (#102), make onRender work and d…

Navigation Menu

Repository navigation

<RollbarContext /> implementation doesn't match docs #88

1 - RollbarContext requires the onRender prop

2 - RollbarContext type is incorrect

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

<RollbarContext /> implementation doesn't match docs #88

Description

1 - RollbarContext requires the onRender prop

2 - RollbarContext type is incorrect

Activity

gazpachu commented on Jun 19, 2023

gazpachu commented on Jun 19, 2023

gazpachu commented on Jun 26, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions