Skip to content

feat: add repository validation runner - #419

Closed
ronak-guliani wants to merge 3 commits into
mainfrom
feat/validation-repository-runner
Closed

ronak-guliani wants to merge 3 commits into
mainfrom
feat/validation-repository-runner

Conversation

@ronak-guliani

Copy link
Copy Markdown
Owner

Summary

  • add a pure ValidationPolicy that maps normalized changed paths and scope to deduplicated validation requirements
  • add a non-persistent RepositoryValidationRunner with allowlisted gate IDs, fixed argv, shared process budgeting, bounded output, timing, interruption/cancellation, and artifact descriptors
  • keep browser validation as a planned requirement only; the repository runner rejects it without spawning a process

Interfaces

  • ValidationPolicy.classify({ changedPaths, scope }) -> ValidationPlan
  • RepositoryValidationRunner.run({ gates }) -> RepositoryValidationRunResult
  • ValidationArtifactStore is injected so durable output persistence is explicit and independently testable

Validation

  • focused validation module tests: 13 passed
  • related Git/subprocess tests: 154 passed
  • pnpm fmt:check: passed
  • pnpm lint: passed with existing repository warnings
  • pnpm typecheck: passed with existing Effect language-service suggestions
  • pnpm test: 2,446 passed, 9 skipped; 282 files passed, 2 skipped

Tested revision: e952aa366021991e4430ee0f306045bbcfd66a6f4

Integration notes

The coordinator can add one adapter that turns the policy's requirement IDs into RepositoryValidationGateSpec values and supplies an artifact store. No orchestration commands/events, persistence state, or browser automation are wired here.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Sep 18, 2026
@ronak-guliani

Copy link
Copy Markdown
Owner Author

Superseded by #420: the repository runner and policy slice was integrated via #423 and carries further review fixes on the lifecycle line (scoped artifact keys, focused test files, abort-on-interrupt). Closing as redundant — reopen if slice-first ordering is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant