Skip to content

Refactor truncate floor and ceil duplicated part #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 1 commit into from
Jul 27, 2025
+30 −65
Merged

Refactor truncate floor and ceil duplicated part #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 30 additions & 65 deletions ext/bigdecimal/bigdecimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2450,6 +2450,33 @@ BigDecimal_round(int argc, VALUE *argv, VALUE self)
return CheckGetValue(c);
}

static VALUE
BigDecimal_truncate_floor_ceil(int argc, VALUE *argv, VALUE self, unsigned short rounding_mode)
{
ENTER(5);
BDVALUE c, a;
int iLoc;
VALUE vLoc;
size_t mx, pl = VpSetPrecLimit(0);

if (rb_scan_args(argc, argv, "01", &vLoc) == 0) {
iLoc = 0;
}
else {
iLoc = NUM2INT(vLoc);
}

GUARD_OBJ(a, GetBDValueMust(self));
mx = (a.real->Prec + 1) * BASE_FIG;
GUARD_OBJ(c, NewZeroWrapLimited(1, mx));
VpSetPrecLimit(pl);
VpActiveRound(c.real, a.real, rounding_mode, iLoc);
if (argc == 0) {
return BigDecimal_to_i(CheckGetValue(c));
}
return CheckGetValue(c);
}

/* call-seq:
* truncate(n)
*
Expand All @@ -2472,28 +2499,7 @@ BigDecimal_round(int argc, VALUE *argv, VALUE self)
static VALUE
BigDecimal_truncate(int argc, VALUE *argv, VALUE self)
{
ENTER(5);
BDVALUE c, a;
int iLoc;
VALUE vLoc;
size_t mx, pl = VpSetPrecLimit(0);

if (rb_scan_args(argc, argv, "01", &vLoc) == 0) {
iLoc = 0;
}
else {
iLoc = NUM2INT(vLoc);
}

GUARD_OBJ(a, GetBDValueMust(self));
mx = (a.real->Prec + 1) * BASE_FIG;
GUARD_OBJ(c, NewZeroWrapLimited(1, mx));
VpSetPrecLimit(pl);
VpActiveRound(c.real, a.real, VP_ROUND_DOWN, iLoc); /* 0: truncate */
if (argc == 0) {
return BigDecimal_to_i(CheckGetValue(c));
}
return CheckGetValue(c);
return BigDecimal_truncate_floor_ceil(argc, argv, self, VP_ROUND_DOWN);
}

/* Return the fractional part of the number, as a BigDecimal.
Expand Down Expand Up @@ -2532,28 +2538,7 @@ BigDecimal_frac(VALUE self)
static VALUE
BigDecimal_floor(int argc, VALUE *argv, VALUE self)
{
ENTER(5);
BDVALUE c, a;
int iLoc;
VALUE vLoc;
size_t mx, pl = VpSetPrecLimit(0);

if (rb_scan_args(argc, argv, "01", &vLoc)==0) {
iLoc = 0;
}
else {
iLoc = NUM2INT(vLoc);
}

GUARD_OBJ(a, GetBDValueMust(self));
mx = (a.real->Prec + 1) * BASE_FIG;
GUARD_OBJ(c, NewZeroWrapLimited(1, mx));
VpSetPrecLimit(pl);
VpActiveRound(c.real, a.real, VP_ROUND_FLOOR, iLoc);
if (argc == 0) {
return BigDecimal_to_i(CheckGetValue(c));
}
return CheckGetValue(c);
return BigDecimal_truncate_floor_ceil(argc, argv, self, VP_ROUND_FLOOR);
}

/* call-seq:
Expand All @@ -2576,27 +2561,7 @@ BigDecimal_floor(int argc, VALUE *argv, VALUE self)
static VALUE
BigDecimal_ceil(int argc, VALUE *argv, VALUE self)
{
ENTER(5);
BDVALUE c, a;
int iLoc;
VALUE vLoc;
size_t mx, pl = VpSetPrecLimit(0);

if (rb_scan_args(argc, argv, "01", &vLoc) == 0) {
iLoc = 0;
} else {
iLoc = NUM2INT(vLoc);
}

GUARD_OBJ(a, GetBDValueMust(self));
mx = (a.real->Prec + 1) * BASE_FIG;
GUARD_OBJ(c, NewZeroWrapLimited(1, mx));
VpSetPrecLimit(pl);
VpActiveRound(c.real, a.real, VP_ROUND_CEIL, iLoc);
if (argc == 0) {
return BigDecimal_to_i(CheckGetValue(c));
}
return CheckGetValue(c);
return BigDecimal_truncate_floor_ceil(argc, argv, self, VP_ROUND_CEIL);
}

/* call-seq:
Expand Down
Loading