Skip to content

🐛 Fix empty SearchResult#to_sequence_set #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 2 commits into from
Apr 17, 2026
Merged

🐛 Fix empty SearchResult#to_sequence_set #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a36d6eb
🐛 Fix empty SearchResult#to_sequence_set
nevans Apr 17, 2026
4299df8
📚 Document SearchResult#to_sequence_set is sorted
nevans Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/net/imap/search_result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,11 @@ def to_s(type = "SEARCH")
# Net::IMAP::SearchResult[9, 1, 2, 4, 10, 12, 3, modseq: 123_456]
# .to_sequence_set
# # => Net::IMAP::SequenceSet["1:4,9:10,12"]
def to_sequence_set; SequenceSet[*self] end
#
# >>>
# *NOTE:* +SORT+ order is not preserved. The result will be sorted.
#
def to_sequence_set; empty? ? SequenceSet.empty : SequenceSet[to_a] end

def pretty_print(pp)
return super if modseq.nil?
Expand Down
17 changes: 17 additions & 0 deletions test/net/imap/test_search_result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,21 @@ class SearchDataTests < Net::IMAP::TestCase
assert_equal("99 111 44 (MODSEQ 999)",
Net::IMAP::SearchResult[99, 111, 44, modseq: 999].to_s(nil))
end

test "#to_sequence_set" do
assert_equal("1,3", Net::IMAP::SearchResult[1, 3].to_sequence_set.to_s)
assert Net::IMAP::SearchResult[1, 3].to_sequence_set.frozen?
assert_equal("1:3", Net::IMAP::SearchResult[1, 2, 3].to_sequence_set.to_s)
assert_equal(
"44,99,111",
Net::IMAP::SearchResult[99, 111, 44, modseq: 999].to_sequence_set.to_s
)
assert_equal(
"1:4,9:10,12",
Net::IMAP::SearchResult[9, 1, 2, 3, 4, 10, 12].to_sequence_set.to_s
)
assert_equal(Net::IMAP::SequenceSet.empty,
Net::IMAP::SearchResult[].to_sequence_set)
assert Net::IMAP::SearchResult[].to_sequence_set.frozen?
end
end