Update Array#2987
Merged
soutaro merged 23 commits intoJun 24, 2026
Merged
Conversation
sampersand
force-pushed
the
swesterman/2026-05-22/update-Array
branch
2 times, most recently
from
786a245 to
31a4a54
Compare
sampersand
commented
Jun 3, 2026
| # | ||
| alias any? all? | ||
| def any?: () -> bool | ||
| | (_Pattern[E] pattern) -> bool |
Contributor
Author
There was a problem hiding this comment.
TODO: Use RBS::Ops:_Matches
sampersand
force-pushed
the
swesterman/2026-05-22/update-Array
branch
2 times, most recently
from
1eef064 to
0fa718e
Compare
soutaro
reviewed
Jun 4, 2026
| def bsearch: () -> ::Enumerator[E, E?] | ||
| | () { (E) -> (true | false) } -> E? | ||
| | () { (E) -> ::Integer } -> E? | ||
| def bsearch: () { (E element) -> (Numeric | bool?) } -> E? |
Member
There was a problem hiding this comment.
I'm not sure if this works for actual type checkers, but these definitions are not equivalent.
Returning both true | false and Integer from a block is not allowed to bsearch, I think.
Contributor
There was a problem hiding this comment.
[…].bsearch { it.positive? and it } # false | Integer
Member
There was a problem hiding this comment.
https://docs.ruby-lang.org/en/4.0/language/bsearch_rdoc.html#label-Binary+Searching
The block should not mix the modes by sometimes returning true or false and other times returning a numeric value, but this is not checked.
soutaro
reviewed
Jun 4, 2026
sampersand
force-pushed
the
swesterman/2026-05-22/update-Array
branch
from
cc52661 to
4691c6d
Compare
sampersand
force-pushed
the
swesterman/2026-05-22/update-Array
branch
from
2f1d30d to
21d3886
Compare
sampersand
commented
Jun 9, 2026
sampersand
left a comment
sampersand
left a comment
Contributor
Author
There was a problem hiding this comment.
Did final check, should good
sampersand
force-pushed
the
swesterman/2026-05-22/update-Array
branch
from
dfe3641 to
a814469
Compare
soutaro
reviewed
Jun 19, 2026
| # Array](rdoc-ref:Array@Methods+for+Creating+an+Array). | ||
| # | ||
| def self.[]: [U] (*U) -> ::Array[U] | ||
| def self.[]: [U] (*U) -> Array[U] # this technically returns a subclass, but `instance(self)` isn't a thing |
Member
There was a problem hiding this comment.
I think instance would work. However instance[U] isn't a thing.
soutaro
reviewed
Jun 19, 2026
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
soutaro
reviewed
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely updates
Array's signatures, and rewrites the test harness to work with it.Note that there's some
# where E: ...comments strewn about in the code. This marks places where, when we eventually get around to implementing thewhereclause, we should implement them in the Array.