Undeprecate bundle show#4586
Conversation
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
@NeimadTL Thanks for not forgetting about this ❤️
Made one comment, but other than that it seems all good!
|
@deivid-rodriguez , just made the recommended changes. Thanks again for all the information ;) |
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
One final round of comments, but seems mostly ready!
|
@deivid-rodriguez , hopefully good this time around. Thanks for your feedback |
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Sorry I keep noticing more things we should delete 😅.
The timeline of how `show` got deprecated is on this issue's comment: ruby#3243 (comment). We eventually decided to undeprecate `show` as no apparent reason was found to deprecate it.
deivid-rodriguez
force-pushed
the
enhancement/undeprecate_bundle_show
branch
from
ca40176 to
dad016c
Compare
|
Everything was addressed but there was one leftover issue where you had unintentionally committed a Thanks so much @NeimadTL for your contribution! ❤️ |
|
@deivid-rodriguez , thanks for fixing the leftover for me and thanks for help overall 🥇 |
…_show Undeprecate bundle show (cherry picked from commit 1c70b05)
…_show Undeprecate bundle show (cherry picked from commit 1c70b05)
4 participants
The timeline of how show got deprecated is on this issue's comment: #3243 (comment). We eventually decided to undeprecate show as no apparent reason was give
to deprecate it.
What was the end-user or developer problem that led to this PR?
bundle showwas deprecated for no apparent reason.timeline (see here)
What is your fix for the problem, implemented in this PR?
bundle showhas been undeprecated.Closes #3243.
Make sure the following tasks are checked