Simplify and improve some specs#4590
Merged
Merged
Conversation
deivid-rodriguez
force-pushed
the
simplify_and_improve_some_specs
branch
from
4341646 to
26e3cea
Compare
deivid-rodriguez
force-pushed
the
simplify_and_improve_some_specs
branch
from
a4274d9 to
78f56fd
Compare
In real life, bundler is never required with an absolute path. Make our specs require bundler the way it's required in real life so that the bundler activation code present in rubygems is also tested.
deivid-rodriguez
force-pushed
the
simplify_and_improve_some_specs
branch
from
78f56fd to
25cce71
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
May 25, 2021
Simplify and improve some specs (cherry picked from commit 05cbb70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Some specs test scenarios that don't really happen in real life, like requiring bundler with an absolute path.
What is your fix for the problem, implemented in this PR?
Make sure we test realworld case scenarios and also simplify related specs.
Make sure the following tasks are checked