Skip to content

Avoid printing "Using ..." messages when version has not changed - #6804

Merged
deivid-rodriguez merged 1 commit into
masterfrom
suppress_install_using_messages
Jul 10, 2023
Merged

deivid-rodriguez merged 1 commit into
masterfrom
suppress_install_using_messages

Conversation

@deivid-rodriguez

Copy link
Copy Markdown
Contributor

What was the end-user or developer problem that led to this PR?

Current default output is a bit too verbose.

What is your fix for the problem, implemented in this PR?

Avoid printing using messages when version has not changed.

Closes #6796.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez changed the title Avoid printing using messages when version has not changed Avoid printing "Using ..." messages when version has not changed Jul 7, 2023
@deivid-rodriguez
deivid-rodriguez merged commit 20e6da4 into master Jul 10, 2023
@deivid-rodriguez
deivid-rodriguez deleted the suppress_install_using_messages branch July 10, 2023 18:37
deivid-rodriguez added a commit that referenced this pull request Jul 12, 2023
Avoid printing "Using ..." messages when version has not changed

(cherry picked from commit 20e6da4)
@n-rodriguez

Copy link
Copy Markdown

Thank you! ❤️

@deivid-rodriguez

Copy link
Copy Markdown
Contributor Author

No problem!

Fryguy added a commit to Fryguy/bundler-inject that referenced this pull request Jul 27, 2023
Bundler 2.4.17 removed the "Using" statements in
ruby/rubygems#6804
which were relied upon by these specs.
mike-burns added a commit to thoughtbot/factory_bot_rails that referenced this pull request Sep 1, 2023
The latest release of Bundler [removed] the "Using " lines from the output
unless `--verbose` is passed. Ruby 3 ships with its own Bundler, which
still has that line, but Ruby 2.7 does not, so we install the latest on
CI. This is causing those tests to fail.

[removed]: ruby/rubygems#6804
mike-burns added a commit to thoughtbot/factory_bot_rails that referenced this pull request Sep 1, 2023
The latest release of Bundler [removed] the "Using " lines from the output
unless `--verbose` is passed. Ruby 3 ships with its own Bundler, which
still has that line, but Ruby 2.7 does not, so we install the latest on
CI. This is causing those tests to fail.

[removed]: ruby/rubygems#6804
@dentarg

dentarg commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Is there an ENV to enable the Using ... message? I know about bundle install --verbose but when using https://github.com/ruby/setup-ruby with bundler-cache you don't control the bundle install command

I fail to find anything suitable on https://bundler.io/v2.5/man/bundle-config.1.html

@deivid-rodriguez

Copy link
Copy Markdown
Contributor Author

Maybe DEBUG?

@dentarg

dentarg commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Yes 😅 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bundler install --new-flag. (for any green / Bundler.ui.confirm output)

4 participants