Unexpected "Syntax OK"

[nobu]

The syntax_suggest 0.0.1 reports "Syntax OK" when a library loaded with -r option has a syntax error.

$ echo break > /tmp/break.rb 

$ ruby --disable=syntax_suggest -r/tmp/break -ep 
/tmp/break.rb: /tmp/break.rb:1: Invalid break (SyntaxError)

$ ruby -r/tmp/break -ep 
/tmp/break.rb: Syntax OK/tmp/break.rb:1: Invalid break (SyntaxError)

[schneems]

Thank you for the report i'm able to reproduce this:

$ cat /tmp/break.rb
break
⛄️ 3.1.2 🚀 /Users/rschneeman/Documents/projects/syntax_suggest (main)
$ ruby -Ilib -rsyntax_suggest -r/tmp/break -ep
Syntax OK
/tmp/break.rb: /tmp/break.rb:1: Invalid break (SyntaxError)

It looks like Ripper does not know this is invalid code:

$ ruby -rripper -e "puts Ripper.new(File.read('/tmp/break.rb')).tap(&:parse).error?"
false
$ ruby -rripper -e "puts Ripper.new('break').tap(&:parse).error?"
false

Should I file a ticket on bugs.ruby-lang ?

I can also fix the output, if we know it's triggered via a SyntaxError (instead of via the CLI) then we should never emit "Syntax OK" as it makes no sense.