Skip to content

Fix truncated Chrome WS URL that results in intermittent Ferrum::DeadBrowserError #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
route merged 1 commit into from
Jan 18, 2023
+1 −1
Merged

Fix truncated Chrome WS URL that results in intermittent Ferrum::DeadBrowserError #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ferrum/browser/process.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def parse_ws_url(read_io, timeout)
output = ""
start = Utils::ElapsedTime.monotonic_time
max_time = start + timeout
regexp = %r{DevTools listening on (ws://.*)}
regexp = %r{DevTools listening on (ws://.*[a-zA-Z0-9-]{36})}
while (now = Utils::ElapsedTime.monotonic_time) < max_time
begin
output += read_io.read_nonblock(512)
Expand Down