Move from Azure to AWS S3 for blob storage - #5023
Conversation
|
|
||
| logger.info("Copying the database...") | ||
| backup_filename = "#{current_time}.rds.dump" | ||
| backup_filename = "#{Rails.env}-#{current_time}.rds.dump" |
| storage_account_name: account_name, | ||
| storage_access_key: account_key | ||
| ) | ||
| client = Aws::S3::Client.new(region: 'us-east-2') |
There was a problem hiding this comment.
Is this the same as
client = ActiveStorage::Blob.services.fetch(:amazon)
There was a problem hiding this comment.
Basically. In this case I'm going straight to the client rather than doing it in a roundabout way through ActiveStorage.
|
Is CORS enabled on S3? Will be needed for direct uploads, introduced here: #4937 |
|
Yep, it should be! |
| class MoveAzureBlobsToS3 < ActiveRecord::Migration[7.2] | ||
| # https://stackoverflow.com/questions/71699789/activestorage-transfer-all-assets-from-one-bucket-to-another-bucket | ||
| def up | ||
| return unless Rails.env.staging? |
There was a problem hiding this comment.
Ah, so only run this migration in staging. I see.
|
We'll let @cielf merge as part of a controlled staging validation (upload files, merge this, see that they're still there, upload more files) |
|
I was hoping to get to this today but life interfered. Hopefully Friday. |
|
Merging for staging testing now. |
|
@dorner I think we have to revert this -- and retry -- |
|
@dorner: Your PR |
4 participants
This PR does the following:
amazonstorage provider. I've set up blob storage buckets for both production and staging.amazonfor staging only for now.My suggestion for testing:
Once testing is complete, this branch is safe to merge, and we can put in a further PR that will apply these changes to prod.