634 beacons index page improve#673
Merged
dmitrytrager merged 7 commits intoJun 8, 2026
Merged
Conversation
devjona
approved these changes
May 22, 2026
devjona
left a comment
devjona
left a comment
Collaborator
There was a problem hiding this comment.
@davidpgero thank you for working on this ticket!
I think @dmitrytrager has good suggestions; I'll give my approval but please include his suggestions when you have the time.
Contributor
Author
|
thank you for the review @dmitrytrager and @devjona! I updated the PR as suggested. |
dmitrytrager
approved these changes
May 31, 2026
Collaborator
|
@davidpgero please check linter issues |
Contributor
Author
|
@devjona , I'm sorry, I missed the linter. :( I updated the code, and the linter is green on my local. Somehow the |
dmitrytrager
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves #634
What Changed? And Why Did It Change?
How Has This Been Tested?
Please Provide Screenshots
Additional Comments
Please, check the regions in the seed data. Maybe we can come up a better seed data there.