bitreq: Add RFC 9112 compliance test vectors#660
Open
tnull wants to merge 3 commits into
Open
Conversation
Exercise the HTTP/1.1 wire grammar so request generation and response parsing gaps are visible before behavior is changed. Co-Authored-By: HAL 9000
Cover response length and chunk decoding rules so incomplete or ambiguous messages cannot pass unnoticed. Co-Authored-By: HAL 9000
Cover persistence, closure, and pipelining rules so connection reuse can be corrected against explicit expectations. Refs: rust-bitcoin#659 Co-Authored-By: HAL 9000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #659 we recently discovered that we aren't fully compliant with RFC 9112 / HTTP 1.1.
As a first step of mitigation, we here add some test vectors that cover the central points. We opted to mark the (33!) failing checks as
ignored, so we can revisit and fix them in following PRs (instead of cramming everything into one PR).And more minor: