Repository navigation
Create an empty crypto crate - #5283
Merged
Merged
Conversation
Member
Author
|
If this merges @apoelstra please tag and release so we can squat the name. |
tcharding
force-pushed
the
push-qnswptzywomp
branch
from
November 13, 2025 00:55
344d360 to
f289278
Compare
tcharding
force-pushed
the
push-qnswptzywomp
branch
from
November 13, 2025 00:55
f289278 to
0e736bc
Compare
In preparation for crate smashing the `crypto` module create an empty crate so we can grab the name on crates.io. I don't currently know whats the pros and cons of moving just keys to moving everything in the `crypto` module. So the manifest description is a bit vague. FTR `bitcoin-keys` and `bitcoin_keys` are both taken on crates.io
tcharding
force-pushed
the
push-qnswptzywomp
branch
from
November 13, 2025 04:02
0e736bc to
7d8172e
Compare
Member
|
I'm reasonably sure we're going to need to move signature types to the same crate as the keys, so concept ACK. |
Member
|
Published. Didn't bother making a tag. |
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for crate smashing the
cryptomodule create an empty crate so we can grab the name on crates.io.I don't currently know whats the pros and cons of moving just keys to moving everything in the
cryptomodule. So the manifest description is a bit vague.FTR
bitcoin-keyandbitcoin_keysare both taken on crates.iobitcoin-keyis however owned by klebs6 who has given us names in the past.bitcoin_keysis owned by Maxim.