Skip to content

dragonfly: Parse version from headers rather than CLI - #5580

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
tgross35:dragonfly-version
Oct 16, 2026
Merged

tgross35 merged 1 commit into
rust-lang:mainfrom
tgross35:dragonfly-version

Conversation

@tgross35

@tgross35 tgross35 commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

This matches what is done on other platforms to avoid relying on local uname.

Link: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d1f4fb943c73e2b61ddabff6aa48ce7551db72f4/sys/sys/param.h#L273

@tgross35

tgross35 commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@chitao1234 would you mind taking a look at this? It should be about the same as other BSDs but I am not able to test.

@chitao1234

Copy link
Copy Markdown
Contributor

Sure, happy to take a look. Unfortunately, during my testing, I found that malloc_usable_size, posix_fallocate, getentropy, and fdatasync all have their version thresholds set to 6.0, but malloc_usable_size is only available on 6.4+ and the other three are available on 6.2+, which causes a test failure on 6.2 and 6.0.

@tgross35

Copy link
Copy Markdown
Member Author

@chitao1234 does this at least get the same versions? I imagine there are some possible test updates, but they shouldn't block this.

@chitao1234

Copy link
Copy Markdown
Contributor

Sorry about not respoding clearing in the previos reply. The version parsing part is all good.

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 16, 2026
@tgross35

Copy link
Copy Markdown
Member Author

Thanks for confirming! Please feel free to follow up with fixes for those things, at least on the latest version.

I'm not sure how popular this platform is but you might be able to make the case for promoting it to tier 2 if it gets target maintainers (I know you have expressed interest in that). If that happens then we could test it here and it would get built from rust-lang's CI.

@tgross35
tgross35 added this pull request to the merge queue Oct 16, 2026
Merged via the queue into rust-lang:main with commit d6e5956 Oct 16, 2026
60 checks passed
@tgross35 tgross35 mentioned this pull request Oct 16, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Oct 16, 2026
This matches what is done on other platforms to avoid relying on local
`uname`.

Link: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d1f4fb943c73e2b61ddabff6aa48ce7551db72f4/sys/sys/param.h#L273

(backport <#5580>)
(cherry picked from commit d6e5956)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants