Repository navigation
dragonfly: Parse version from headers rather than CLI - #5580
Conversation
This matches what is done on other platforms to avoid relying on local `uname`. Link: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d1f4fb943c73e2b61ddabff6aa48ce7551db72f4/sys/sys/param.h#L273
a13a525 to
cec2dfd
Compare
|
@chitao1234 would you mind taking a look at this? It should be about the same as other BSDs but I am not able to test. |
|
Sure, happy to take a look. Unfortunately, during my testing, I found that |
|
@chitao1234 does this at least get the same versions? I imagine there are some possible test updates, but they shouldn't block this. |
|
Sorry about not respoding clearing in the previos reply. The version parsing part is all good. |
|
Thanks for confirming! Please feel free to follow up with fixes for those things, at least on the latest version. I'm not sure how popular this platform is but you might be able to make the case for promoting it to tier 2 if it gets target maintainers (I know you have expressed interest in that). If that happens then we could test it here and it would get built from rust-lang's CI. |
This matches what is done on other platforms to avoid relying on local `uname`. Link: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d1f4fb943c73e2b61ddabff6aa48ce7551db72f4/sys/sys/param.h#L273 (backport <#5580>) (cherry picked from commit d6e5956)
This matches what is done on other platforms to avoid relying on local
uname.Link: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d1f4fb943c73e2b61ddabff6aa48ce7551db72f4/sys/sys/param.h#L273