Repository navigation
Add support for Emscripten v4.0.12 to v6.0.11 - #5610
Conversation
madsmtm
changed the title
| # Note: keep in sync with: | ||
| # https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-unknown-emscripten.md#requirements | ||
| emsdk_version=3.1.68 | ||
| emsdk_version=6.0.11 |
There was a problem hiding this comment.
Ideally, we should test a range of emscripten versions, though I'm unsure how we'd go about doing that?
WDYT @tgross35?
There was a problem hiding this comment.
It wouldn't hurt but I also wouldn't prioritize it, hopefully any ABI breaks continue to be small.
rustbot
added
A-CI
| // Non-Emscripten or version >= 3.1.42. | ||
| _ => (), | ||
| if let Some(v) = emcc_version_code() { | ||
| // 3.1.42 |
There was a problem hiding this comment.
Minimum supported version is 4.0.0 so let's drop this.
There was a problem hiding this comment.
But minimum supported version is only very recently v4.0.0, whereas libc can still be used with lower MSRV?
There was a problem hiding this comment.
It's not much code to keep so if there's a reason then it's probably fine.
There was a problem hiding this comment.
It's pretty small so we may as well keep it around for now. Could we document the versions we support at https://doc.rust-lang.org/beta/rustc/platform-support/wasm32-unknown-emscripten.html?
There was a problem hiding this comment.
There was a problem hiding this comment.
Argh why do I always wind up on the beta version of those pages, thanks for the link
madsmtm
added
the
stable-nominated
madsmtm
changed the title
| # Note: keep in sync with: | ||
| # https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-unknown-emscripten.md#requirements | ||
| emsdk_version=3.1.68 | ||
| emsdk_version=6.0.11 |
There was a problem hiding this comment.
It wouldn't hurt but I also wouldn't prioritize it, hopefully any ABI breaks continue to be small.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Sry for the delay, changed it to use |
tgross35
added
stable-applied
Update for ABI-breaking changes to Emscripten.
See also this Zulip discussion on how to handle these in general.
CC target maintainers @hoodmane @juntyr
See also last update: #3962