Repository navigation
test: Skip getexecpath on OpenBSD below 8.0 - #5670
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
tgross35
requested changes
Oct 26, 2026
Member
There was a problem hiding this comment.
Code changes look fine but we require all communication to be handwritten, including PR descriptions and commit messages. See https://forge.rust-lang.org/policies/llm-usage.html#-banned
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
`getexecpath` (added in rust-lang#5465) only exists since OpenBSD 8.0, so on 7.9 the generated C fails to compile and libc-test can't build; this skips it below 8.0. Assisted-by: LLM
vignesh-chaturvedi
force-pushed
the
openbsd-getexecpath
branch
from
October 26, 2026 19:51
c992b6c to
9a71b85
Compare
vignesh-chaturvedi
changed the title
getexecpath for OpenBSD < 8.0
Contributor
Author
|
Sorry, it's on me. I rewrote the description and commit message myself. @rustbot ready |
tgross35
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rustbot label +stable-nominated
#5465 added
getexecpath, which OpenBSD only has since 8.0 (man page). On 7.9 the generated C fails withuse of undeclared identifier 'getexecpath'and the build script panics. Skip it whenVERSIONS.openbsdis below 8.0.cc @brad0 since you added the binding.