Skip to content

rustdoc: Enabling mergeable CCI broke the search functionality for the stdlib and for our internal docs #162334

Closed
#162346
Closed
rustdoc: Enabling mergeable CCI broke the search functionality for the stdlib and for our internal docs#162334
#162346
Labels
A-rustdoc-searchArea: Rustdoc's search featureC-bugCategory: This is a bug.E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleP-criticalCritical priorityS-has-bisectionStatus: A bisection has been found for this issueT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
Milestone
1.100.0

Description

@fmease
fmease
opened on Sep 5, 2026

Over at https://doc.rust-lang.org/nightly/nightly-rustc, it's impossible to find rustc_ast::ast::Attribute directly via the search feature.

Attribute

It doesn't matter if I search rustc_ast::ast::Attribute, rustc_ast::Attribute, ast::Attribute or Attribute.

Image

ast::Attribute & rustc_ast::Attribute & rustc_ast::ast::Attribute

Here, it "at least" indirectly lists the correct type as part of an associated function.

Image

Activity

  1. fmease
    added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-rustdoc-searchArea: Rustdoc's search feature
    on Sep 5, 2026
  2. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
    on Sep 5, 2026
  3. fmease
    added
    E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Sep 5, 2026

  4. fmease commented on Sep 5, 2026

    @fmease
    fmease
    on Sep 5, 2026
    MemberAuthor

    This feels like a regression.

    I don't know if it's a rustdoc regression, a bootstrap regression or if it's only exhibited now because we've changed the compiler crates in some way like adding some public re-exports of rustc_ast::ast or rustc_ast::ast::Attribute to some other compiler crate (CC #145870 which is only tangentially related).

  5. theemathas commented on Sep 5, 2026

    @theemathas
    theemathas
    on Sep 5, 2026
    Contributor

    This also affects searching of the standard library (as of 0ed41eb41 2026-09-04). Searching for "PathBuf" doesn't find the PathBuf type. https://doc.rust-lang.org/nightly/std/index.html?search=PathBuf

    Image
  6. theemathas
    added
    regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.
    on Sep 5, 2026
  7. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Sep 5, 2026
  8. fmease
    added
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    on Sep 5, 2026

  9. fmease commented on Sep 5, 2026

    @fmease
    fmease
    on Sep 5, 2026
    MemberAuthor

    Most likely due to #161716? That PR got merged 2 days ago, so part of nightly-2026-09-03 (rustc version) aka nightly-2026-09-04 (toolchain name) and it's very plausible that it messed with the search indices.

    cc @notriddle

  10. fmease
    added
    S-has-bisectionStatus: A bisection has been found for this issue
    and removed
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    on Sep 5, 2026

  11. 3 remaining items

  12. fmease
    removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Sep 5, 2026
  13. Mark-Simulacrum
    added this to the 1.100.0 milestone on Sep 5, 2026

  14. jieyouxu commented on Sep 5, 2026

    @jieyouxu
    jieyouxu
    on Sep 5, 2026
    Member

    I'll try this locally with a revert 🤔 If it's due to #161716 I'd like to revert / reland that, it's not trivial certainly.

  15. jieyouxu commented on Sep 5, 2026

    @jieyouxu
    jieyouxu
    on Sep 5, 2026
    Member

    I looked at the rustc-docs locally too when reviewing the PR but also did not notice the difference 😓

  16. jieyouxu commented on Sep 5, 2026

    @jieyouxu
    jieyouxu
    on Sep 5, 2026
    Member

    Posted a revert: #162339

  17. notriddle commented on Sep 5, 2026

    @notriddle
    notriddle
    on Sep 5, 2026
    Contributor

    And a fix #162346

    Do we still want to land the revert?

  18. Zalathar commented on Sep 6, 2026

    @Zalathar
    Zalathar
    on Sep 6, 2026
    Member

    Given that the fix-forward is in rustdoc rather than bootstrap, I’m inclined to follow the usual default practice of rolling back to a known-OK state and then working forwards from there, to avoid the risk of having an even bigger mess to revert.

  19. notriddle commented on Sep 6, 2026

    @notriddle
    notriddle
    on Sep 6, 2026
    Contributor

    Okay, let's do that. The fix-forward shouldn't conflict with the revert, anyway.

  20. JonathanBrouwer
    added a commit that references this issue on Sep 6, 2026

    Rollup merge of rust-lang#162339 - jieyouxu:revert-mergeable-cci, r=K…

    fbb1ea3
  21. rust-bors
    added a commit that references this issue on Sep 6, 2026

    Unrolled build for #162339 in rollup 162362

    1451a27
  22. JonathanBrouwer
    added 3 commits that reference this issue on Sep 10, 2026

    Add regression test for PathBuf not showing up

    be3136b

    Rollup merge of rust-lang#162346 - notriddle:rustdoc-merge-type, r=lo…

    031d6e6

    Rollup merge of rust-lang#162346 - notriddle:rustdoc-merge-type, r=lo…

    19f7664
  23. rust-bors
    closed this as completedin 19f7664on Sep 11, 2026
  24. rust-bors
    added a commit that references this issue on Sep 11, 2026

    Unrolled build for #162346 in rollup 162612

    301e456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-searchArea: Rustdoc's search featureC-bugCategory: This is a bug.E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleP-criticalCritical priorityS-has-bisectionStatus: A bisection has been found for this issueT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions