Inconsistency in IteratorExt::all and ::any

One of the methods takes &mut self, the other takes self, which is strange, since they are almost exactly the same code.

I'm guessing that IteratorExt::all should take &mut self, like any does.

@aturon

isn't this because all consumes the iterator completely and any only up to the first occurrence?

@oli-obk

@oli-obk both iterators behave the same way, all stops at the first false value, any stops at the first true value.

@Aatch

Thanks for the report, @Aatch. This was a mistake, and both should take &mut self precisely to clarify the consumption semantics.

This should be a trivial fix.

(Should be flagged 1.0-beta P-backcompat-libs)

1.0 beta, P-backcompat-libs.

Navigation Menu