Skip to content

Use statement not migrated #58004

Description

@Swoorup

Use statements doesn't migrate to 2018 when using
cargo fix --edition

I later realized this was on a project which had all warnings turned off. Should rustfix, somehow understand warnings regardless of the warnings suppress by the user?

https://github.com/rustlang-cn/Rust-webapp-starter

Activity

  1. Enselic commented on Nov 19, 2023

    @Enselic
    Member

    Triage: I think this issue should be moved to https://github.com/rust-lang/rustfix/issues?

  2. ehuss commented on Nov 19, 2023

    @ehuss
    Contributor

    I believe this was fixed in 2021 via #85788 and rust-lang/cargo#9588. From what I can gather (the linked repo is no longer available), it sounds like they were allowing warnings. The force-warn system now forces warnings to be applied.

    @Enselic, just FYI, the rustfix repo will be closing soon. Most suggested diagnostic issues should remain in this repo. Also, before transferring an issue, it is helpful to have a reproduction or enough information to assess where the issue lies.

  3. added
    A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.
    and removed on Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-edition-2018Area: The 2018 editionA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions