Update Result docs to the new guarantees#124870
Conversation
This comment has been minimized.
This comment has been minimized.
thomcc
left a comment
There was a problem hiding this comment.
Looks fine except for the unrelated changes.
|
The option module page currently is the central place for NPO documentation. If Result gets those too then things become more scattered. Maybe the Option page should also link to the Result page. |
|
How exactly do you think that would look @the8472 ? The current wording is intended to be a "one way" lookup. "if X is the case, you can count on Y too", but since the guaranteed effects are part of Option then I'm not sure how Option would refer to Result. |
|
Maybe
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
…lnay Update Result docs to the new guarantees The `Option` docs already explain the guarantees given in [RFC 3391](https://github.com/rust-lang/rfcs/blob/master/text/3391-result_ffi_guarantees.md), so all that we need is a paragraph saying that some `Result` type combinations will also qualify. Part of rust-lang#110503
|
Why is this "closed", not "merged"? Something seems to have gone wrong? (Also the commits would ideally have been squashed before landing this, no need to have all these 1-line-fixup commits perpetually in the git history...) |
|
i thought it was handled by bors >.> |
|
Normally bors does nothing, Github marks a PR as merged when its commits all landed.
|
|
https://github.com/rust-lang/rust/blob/master/library/core/src/result.rs#L231-L250 the PR's changes do seem to be in the |
|
Yeah, 9b480da got merged. No idea why this is not reflected in the PR state. |
Note: This PR did get merged, even though Github claims it did not.
The
Optiondocs already explain the guarantees given in RFC 3391, so all that we need is a paragraph saying that someResulttype combinations will also qualify.Part of #110503