[WIP] RIIR HtmlDocCk#125780
Closed
fmease wants to merge 1 commit into
Closed
Conversation
fmease
added
S-waiting-on-author
rustbot
added
A-meta
fmease
added
T-rustdoc
fmease
added
the
S-experimental
Collaborator
|
☔ The latest upstream changes (presumably #126205) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2024
…, r=GuillaumeGomez Update jsondocck directives to follow ui_test-style Context: Comment chain in rust-lang#125813. Follow-up to rust-lang#126788. Use the same temporary approach of "double parsing" until we figure out how we want to support compiletest/ui_test directive "add-ons" for child test runners like HtmlDocCk and JsonDocCk. I didn't touch much of jsondocck because I want to refactor it some other time (for robustness, maintainability and better diagnostics; basically by following a similar design of my WIP HtmlDocCk-next, cc rust-lang#125780). r? `@GuillaumeGomez`
Dylan-DPC
removed
the
S-waiting-on-author
Member
Author
|
Closing in favor of issue #157172 since clearly this PR has stalled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For self-review. Very early.
r? ghost