Skip to content

Migrate issue-37839, track-path-dep-info and track-pgo-dep-info run-make tests to rmake#127378

Merged
bors merged 3 commits into
rust-lang:masterfrom
Oneirical:cetestial-meteorite
Jul 9, 2024
Merged

Migrate issue-37839, track-path-dep-info and track-pgo-dep-info run-make tests to rmake#127378
bors merged 3 commits into
rust-lang:masterfrom
Oneirical:cetestial-meteorite

Conversation

@Oneirical

Copy link
Copy Markdown
Contributor

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: test-various
try-job: dist-x86_64-musl

@rustbot

rustbot commented Jul 5, 2024

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2024
@rustbot

rustbot commented Jul 5, 2024

Copy link
Copy Markdown
Collaborator

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 5, 2024
@jieyouxu

jieyouxu commented Jul 6, 2024

Copy link
Copy Markdown
Member

@bors delegate+ (for try jobs)

@bors

bors commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@jieyouxu

jieyouxu commented Jul 6, 2024

Copy link
Copy Markdown
Member

@bors try

@bors

bors commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ba1539c with merge 8685a17...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
Migrate `issue-37839`, `track-path-dep-info` and `track-pgo-dep-info` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: test-various
try-job: dist-x86_64-musl
@bors

bors commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 8685a17 (8685a17d4298877f3aa0b429fb9e1bab002a169c)

@jieyouxu

jieyouxu commented Jul 6, 2024

Copy link
Copy Markdown
Member

Record: passed on test-various and dist-x86_64-musl.

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about cross-compile case.

Comment on lines +15 to +17
// Merge the profiles
run("main");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: does this need //@ ignore-cross-compile? Or is that kinda implied by //@ needs-profiler-support (even if it is, maybe having the ignore is clearer?)?

@Oneirical Oneirical Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that it's indeed getting implied by //@ needs-profiler-support (you can see the ignored, ignored when profiler support is disabled in the test log), but I added the ignore + reason for clarity. @rustbot review

@jieyouxu

jieyouxu commented Jul 8, 2024

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2024
@Oneirical Oneirical force-pushed the cetestial-meteorite branch from ba1539c to 7c23872 Compare July 8, 2024 14:31
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 8, 2024
@jieyouxu

jieyouxu commented Jul 8, 2024

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup=iffy (profdata shenanigans)

@bors

bors commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 7c23872 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2024
@bors

bors commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7c23872 with merge 99b7134...

@bors

bors commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 99b7134 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 9, 2024
@bors bors merged commit 99b7134 into rust-lang:master Jul 9, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jul 9, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (99b7134): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.8%, secondary -5.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.5%, 3.6%] 6
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.1% [-7.1%, -2.4%] 5
All ❌✅ (primary) 2.8% [2.5%, 3.6%] 6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 705.089s -> 702.448s (-0.37%)
Artifact size: 328.77 MiB -> 328.64 MiB (-0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants