Skip to content

Implement IntoIterator for [&[mut]] Box<[T; N], A>#134021

Open
WaffleLapkin wants to merge 5 commits into
rust-lang:mainfrom
WaffleLapkin:box-arr-into-iter2
Open

Implement IntoIterator for [&[mut]] Box<[T; N], A>#134021
WaffleLapkin wants to merge 5 commits into
rust-lang:mainfrom
WaffleLapkin:box-arr-into-iter2

Conversation

@WaffleLapkin

@WaffleLapkin WaffleLapkin commented Dec 8, 2024 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35 tgross35 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 13, 2024
@WaffleLapkin WaffleLapkin marked this pull request as ready for review December 16, 2024 19:24
@tgross35 tgross35 added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Dec 19, 2024
@bors

bors commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

scottmcm
scottmcm reviewed Feb 24, 2025
View reviewed changes
Comment thread library/alloc/src/boxed/iter.rs
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2025
@WaffleLapkin

WaffleLapkin commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

@scottmcm anything I can do to move this forward?

@rust-bors

This comment was marked as resolved.

Sign in to view
@scottmcm

This comment was marked as resolved.

Sign in to view
@rustbot rustbot assigned Mark-Simulacrum and unassigned scottmcm Feb 8, 2026
Mark-Simulacrum
Mark-Simulacrum requested changes Feb 14, 2026
View reviewed changes

@Mark-Simulacrum Mark-Simulacrum left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this also needs rebasing + FCP, maybe starting with the FCP makes sense since it's not obvious to me this is worth it (especially if it needs an edition change...)

View changes since this review

Comment thread library/alloc/src/boxed/iter.rs Outdated
Comment thread library/alloc/src/boxed/iter.rs Outdated
Comment thread library/alloc/src/boxed/iter.rs Outdated
Comment thread tests/ui/iterators/into-iter-on-arrays-lint.stderr
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the box-arr-into-iter2 branch 2 times, most recently from 33ce55c to a26c96f Compare March 10, 2026 15:10
@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 19, 2026
@craterbot

craterbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-134021 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@theemathas

theemathas commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The crater run seems to be stuck again. Cancelling the run until we figure out what's going on. See https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Crater.20maybe.20stuck.3F/near/604902260

@craterbot cancel

@craterbot

craterbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-134021 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 19, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Jun 20, 2026

Copy link
Copy Markdown
Member

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-157814-crater-rollup/retry-regressed-list.txt

@craterbot

craterbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build c37f0ee
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Jun 20, 2026

Copy link
Copy Markdown
Member

@craterbot abort

@craterbot

craterbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-134021 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 20, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Jun 20, 2026

Copy link
Copy Markdown
Member

@bors try

Figured out crater issue - see #t-infra > Crater maybe stuck? @ 💬 - will fix that separately but for now we'll want a new try job and new crater.

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
@bors
Auto merge of #134021 - WaffleLapkin:box-arr-into-iter2, r=<try>
83ec5b3 
Implement `IntoIterator` for `[&[mut]] Box<[T; N], A>`
@rust-bors

rust-bors Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 83ec5b3 (83ec5b3aeb5925d43b5be7b50c090f2f0336fcc1)
Base parent: fffed27 (fffed276b51cf514622e8d3109d620501cc01670)

@Mark-Simulacrum

Mark-Simulacrum commented Jun 20, 2026

Copy link
Copy Markdown
Member

@craterbot check

@craterbot

craterbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build 83ec5b3
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026
@theemathas

theemathas commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum Using the crate list from another PR was intentional.

@craterbot cancel

@craterbot

craterbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-134021 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 20, 2026
@theemathas

theemathas commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-157814-crater-rollup/retry-regressed-list.txt

@craterbot

craterbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-134021 created and queued.
🤖 Automatically detected try build 83ec5b3
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@programmerjake programmerjake programmerjake left review comments

@scottmcm scottmcm scottmcm left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.