Skip to content

Stabilize substr_range and subslice_range#141266

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
wr7:stabilize_substr_range
Jun 19, 2026
Merged

Stabilize substr_range and subslice_range#141266
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
wr7:stabilize_substr_range

Conversation

@wr7

@wr7 wr7 commented May 20, 2025 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented May 20, 2025

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2025
@wr7 wr7 mentioned this pull request May 19, 2025
Closed
9 tasks
@jieyouxu

jieyouxu commented May 20, 2025

Copy link
Copy Markdown
Member

r? libs-api (needs fcp)

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 20, 2025
@rustbot rustbot assigned BurntSushi and unassigned tgross35 May 20, 2025
@jieyouxu jieyouxu added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2025
@tgross35

tgross35 commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Nominating to discuss possible stabilization. Please see the report at #126769 (comment), and some followup discussion there about API and naming.

@rustbot label +I-libs-api-nominated
r? libs

@rustbot rustbot added I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 5, 2025
@rustbot rustbot assigned ibraheemdev and unassigned BurntSushi Sep 5, 2025
@Amanieu Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 16, 2025
@ibraheemdev ibraheemdev removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2025
@ibraheemdev

ibraheemdev commented Oct 14, 2025

Copy link
Copy Markdown
Member

r? libs-api

@rustbot rustbot assigned the8472 and unassigned ibraheemdev Oct 14, 2025
@ibraheemdev ibraheemdev added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2025
@wr7 wr7 force-pushed the stabilize_substr_range branch from ecd3bb0 to 2c58efe Compare October 29, 2025 14:53
@rustbot

This comment has been minimized.

Sign in to view
@wr7

wr7 commented Nov 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@the8472 The FCP has ended. This should be ready to merge AFAIK

@rustbot

rustbot commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

Error: Label finished-final-comment-period can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@tgross35

tgross35 commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

Last minute concern about the range types used #126769 (comment).

@rust-bors

rust-bors Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #150798) made this pull request unmergeable. Please resolve the merge conflicts.

@wr7 wr7 force-pushed the stabilize_substr_range branch from 2c58efe to 0ab4250 Compare January 8, 2026 14:35
@nik-rev nik-rev mentioned this pull request Apr 2, 2026
Merged
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #141266 - wr7:stabilize_substr_range, r=tgross35
732d335 
Stabilize `substr_range` and `subslice_range`

Closes #126769

[Stabilization Report](#126769 (comment))
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2026
@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 732d335 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  IMAGE: i686-gnu-nopt
  TOOLSTATE_PUBLISH: 1
##[endgroup]
    Updating crates.io index
error: failed to get `getrandom` as a dependency of package `ring v0.17.11`
    ... which satisfies dependency `ring = "^0.17"` of package `rustls v0.23.23`
    ... which satisfies dependency `rustls = "^0.23.22"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `getrandom`

Caused by:

@jhpratt

jhpratt commented Jun 19, 2026

Copy link
Copy Markdown
Member

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 19, 2026
@jhpratt
Rollup merge of rust-lang#141266 - wr7:stabilize_substr_range, r=tgro…
515c925 
…ss35

Stabilize `substr_range` and `subslice_range`

Closes rust-lang#126769

[Stabilization Report](rust-lang#126769 (comment))
@jhpratt jhpratt mentioned this pull request Jun 19, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158117 - jhpratt:rollup-LT9Q8Ul, r=jhpratt
dde0ed4 
Rollup of 3 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158117 - jhpratt:rollup-LT9Q8Ul, r=jhpratt
afdad8c 
Rollup of 3 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158117 - jhpratt:rollup-LT9Q8Ul, r=jhpratt
b761e45 
Rollup of 3 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158117 - jhpratt:rollup-LT9Q8Ul, r=jhpratt
a82a526 
Rollup of 3 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158117 - jhpratt:rollup-LT9Q8Ul, r=jhpratt
cc09c40 
Rollup of 3 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158117 - jhpratt:rollup-LT9Q8Ul, r=jhpratt
d1036ff 
Rollup of 3 pull requests



Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 19, 2026
@jhpratt
Rollup merge of rust-lang#141266 - wr7:stabilize_substr_range, r=tgro…
fe7bd49 
…ss35

Stabilize `substr_range` and `subslice_range`

Closes rust-lang#126769

[Stabilization Report](rust-lang#126769 (comment))
@jhpratt jhpratt mentioned this pull request Jun 19, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158120 - jhpratt:rollup-RPsXyQn, r=jhpratt
08ded94 
Rollup of 4 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158120 - jhpratt:rollup-RPsXyQn, r=jhpratt
64f4818 
Rollup of 4 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158120 - jhpratt:rollup-RPsXyQn, r=jhpratt
5d615c1 
Rollup of 4 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 19, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158124 - JonathanBrouwer:rollup-UKcnc05, r=JonathanBro…
8c2cb2b 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #158040 (Codegen ctors in Runtime mir phase)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158124 - JonathanBrouwer:rollup-UKcnc05, r=JonathanBro…
6eabd1e 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #158040 (Codegen ctors in Runtime mir phase)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158124 - JonathanBrouwer:rollup-UKcnc05, r=JonathanBro…
0c1748c 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #157878 (`impl [const] Default for BTreeMap`)
 - #158040 (Codegen ctors in Runtime mir phase)
 - #141266 (Stabilize `substr_range` and `subslice_range`)
 - #158109 (Change `EarlyCheckNode` from a trait to an enum.)
 - #158118 (Convert '.' to '_' in bootstrap envify)
@rust-bors rust-bors Bot merged commit 22a52cd into rust-lang:main Jun 19, 2026
11 of 12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 19, 2026
rust-timer added a commit that referenced this pull request Jun 19, 2026
@rust-timer
Unrolled build for #141266
968509e 
Rollup merge of #141266 - wr7:stabilize_substr_range, r=tgross35

Stabilize `substr_range` and `subslice_range`

Closes #126769

[Stabilization Report](#126769 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for substr_range and related methods

10 participants

@wr7 @rustbot @jieyouxu @tgross35 @ibraheemdev @rust-log-analyzer @jhpratt @Amanieu @BurntSushi @the8472