Rename the gcc component to gcc-dev by Kobzol · Pull Request #150535 · rust-lang/rust

Kobzol · 2025-12-31T10:12:30Z

In preparation for https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Safe.20rustup.20distribution.20of.20rustc_codegen_gcc/with/565801325.

try-job: dist-x86_64-linux

Kobzol · 2025-12-31T10:12:55Z

@bors try

Rename the gcc component to ci-gcc try-job: dist-x86_64-linux

rust-bors · 2025-12-31T14:14:14Z

☀️ Try build successful (CI)
Build commit: bd01ad8 (bd01ad8bfec1955aff2c8d3397b56de43fcf6046, parent: 629b092f8fab1b0370dfb749c4f5e00e70169dd2)

jyn514 · 2026-01-02T07:30:29Z

perhaps it should be gcc-dev by analogy with rustc-dev?

Kobzol · 2026-01-02T07:47:42Z

The "analogical" LLVM component is actually rust-dev, not rustc-dev (which shows how beautifully named are our components) 😆 But yeah, gcc-dev doesn't sound bad.

To free up the `gcc` name for the actual libgccjit component that we will ship to rustup, and also make it more explicit that this component is internal and for bootstrap usages only.

Because we renamed the CI component. We will have to re-enable it in a follow-up PR.

The `CiGcc` step is not enabled by defaut, so it does not have to be skipped.

Kobzol · 2026-01-02T09:18:29Z

Renamed it to gcc-dev instead.

rustbot · 2026-01-02T09:18:34Z

Some changes occurred in src/tools/opt-dist

cc @Kobzol

rustbot · 2026-01-02T09:18:36Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kobzol · 2026-01-02T09:18:37Z

@bors try

Rename the gcc component to gcc-dev try-job: dist-x86_64-linux

rust-bors · 2026-01-02T13:19:28Z

☀️ Try build successful (CI)
Build commit: a810c3a (a810c3a27ff7df7407db7a9414c17ee1b9c5b7bb, parent: 1b4325211c3228dd10eea12e9b3f749f87363d95)

jyn514 · 2026-01-02T14:54:01Z

it would be funny to rename rust-dev to llvm-dev and rustc-dev to rustc-private, lol. download-ci-rustc doesn't have a dedicated component i don't think, it just reuses rustc-private.

jieyouxu

Thanks

View changes since this review

jieyouxu · 2026-01-05T02:20:22Z

@bors r+ rollup=never

bors · 2026-01-05T02:20:25Z

📌 Commit 2a893bd has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2026-01-05T05:02:24Z

⌛ Testing commit 2a893bd with merge 0d162b2...

bors · 2026-01-05T08:18:25Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 0d162b2 to main...

github-actions · 2026-01-05T08:21:44Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6885bdf (parent) -> 0d162b2 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0d162b25edd5bf0dba9a22e83b614f1113e90474 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 6082.5s -> 8035.1s (+32.1%)
x86_64-gnu-gcc: 3025.6s -> 3887.6s (+28.5%)
x86_64-gnu-llvm-20: 4425.2s -> 5348.3s (+20.9%)
aarch64-apple: 10730.9s -> 8759.0s (-18.4%)
dist-apple-various: 4706.5s -> 3926.8s (-16.6%)
tidy: 172.5s -> 152.1s (-11.8%)
arm-android: 6012.8s -> 5458.9s (-9.2%)
x86_64-gnu-llvm-21-3: 6834.2s -> 6234.9s (-8.8%)
x86_64-gnu-miri: 4265.9s -> 4620.8s (+8.3%)
dist-x86_64-netbsd: 4937.8s -> 5279.1s (+6.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-05T08:59:30Z

Finished benchmarking commit (0d162b2): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.5%, 0.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.1%]	9
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.8%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Cycles

Results (secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	11
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	11

Bootstrap: 473.743s -> 474.733s (0.21%)
Artifact size: 390.82 MiB -> 390.86 MiB (0.01%)

Kobzol · 2026-01-05T09:09:59Z

Noise, this only renamed a CI component.

@rustbot label: +perf-regression-triaged

Kobzol · 2026-01-05T09:10:02Z

Noise, this only renamed a CI component.

@rustbot label: +perf-regression-triaged

This comment has been minimized.

Sign in to view

rust-bors Bot added a commit that referenced this pull request Dec 31, 2025

Auto merge of #150535 - Kobzol:rename-ci-gcc, r=<try>

bd01ad8

Rename the gcc component to ci-gcc try-job: dist-x86_64-linux

This was referenced Dec 31, 2025

Add a dist component for cg_gcc #150538

Merged

Add a dist component for libgccjit #150541

Merged

antoyo reviewed Dec 31, 2025

View reviewed changes

Comment thread src/ci/run.sh Outdated

Kobzol changed the title ~~Rename the gcc component to ci-gcc~~ Rename the gcc component to gcc-dev Jan 2, 2026

Kobzol added 3 commits January 2, 2026 10:18

Rename the gcc component to gcc-dev

7b8d4c6

To free up the `gcc` name for the actual libgccjit component that we will ship to rustup, and also make it more explicit that this component is internal and for bootstrap usages only.

Temporarily disable gcc.download-ci-gcc

4129f3a

Because we renamed the CI component. We will have to re-enable it in a follow-up PR.

Remove unused GCC ignore in opt-dist

2a893bd

The `CiGcc` step is not enabled by defaut, so it does not have to be skipped.

Kobzol force-pushed the rename-ci-gcc branch from 95a398e to 2a893bd Compare January 2, 2026 09:18

Kobzol marked this pull request as ready for review January 2, 2026 09:18

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 2, 2026

rustbot assigned jieyouxu Jan 2, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added a commit that referenced this pull request Jan 2, 2026

Auto merge of #150535 - Kobzol:rename-ci-gcc, r=<try>

a810c3a

Rename the gcc component to gcc-dev try-job: dist-x86_64-linux

jieyouxu approved these changes Jan 5, 2026

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2026

bors merged commit 0d162b2 into rust-lang:main Jan 5, 2026
13 checks passed

rustbot added this to the 1.94.0 milestone Jan 5, 2026

rustbot added the perf-regression Performance regression. label Jan 5, 2026

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 5, 2026

Kobzol deleted the rename-ci-gcc branch January 6, 2026 08:24

github-actions Bot mentioned this pull request Jan 27, 2026

Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345

Open

Uh oh!

Uh oh!

Conversation

Kobzol commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Dec 31, 2025

Uh oh!

This comment has been minimized.

Uh oh!

rust-bors Bot commented Dec 31, 2025

Uh oh!

jyn514 commented Jan 2, 2026

Uh oh!

Kobzol commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Jan 2, 2026

Uh oh!

rustbot commented Jan 2, 2026

Uh oh!

rustbot commented Jan 2, 2026

Uh oh!

Kobzol commented Jan 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jan 2, 2026

Uh oh!

jyn514 commented Jan 2, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jan 5, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jan 5, 2026

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Jan 5, 2026

Uh oh!

Kobzol commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kobzol commented Dec 31, 2025 •

edited

Loading

Kobzol commented Jan 2, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading