Skip to content

Point to the unstable segment of an import path instead of to the whole path#158075

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
oli-obk:confusing-stability
Jun 19, 2026
Merged

Point to the unstable segment of an import path instead of to the whole path#158075
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
oli-obk:confusing-stability

Conversation

@oli-obk

@oli-obk oli-obk commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Brought to you by me being confused why a stable item reported an instability error.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2026
@rustbot

rustbot commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

mejrs
mejrs approved these changes Jun 19, 2026
View reviewed changes

@mejrs mejrs left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f46a9da has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 19, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 19, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 19, 2026
@bors
Auto merge of #158145 - JonathanBrouwer:rollup-89qzt8B, r=JonathanBro…
f428d12 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #158129 (ensure the new solver bootstraps on CI)
 - #158134 (Rename `lint-rust-version` to `hint-msrv`)
 - #157926 (Implement `#[diagnostic::on_unknown]` for modules.)
 - #158075 (Point to the unstable segment of an import path instead of to the whole path)
 - #158084 (`-Znext-solver` Emit error instead of ICE when combining {int, float} var with alias)
 - #158128 (std: use correct low surrogate range in Windows standard I/O code)
 - #158132 (std: correctly report file size on UWP)
 - #158138 (Remove redundant check for `#[loop_match]` and `#[const_continue]`)
@rust-bors rust-bors Bot merged commit d7e8f9f into rust-lang:main Jun 19, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 19, 2026
rust-timer added a commit that referenced this pull request Jun 19, 2026
@rust-timer
Unrolled build for #158075
08affa9 
Rollup merge of #158075 - oli-obk:confusing-stability, r=mejrs

Point to the unstable segment of an import path instead of to the whole path

Brought to you by me being confused why a stable item reported an instability error.
@JonathanBrouwer

JonathanBrouwer commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@rust-timer build 08affa9

@rust-timer

rust-timer commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Missing artifact for sha 08affa9a2062264cc5b2b198c45052f92005aaa3 (https://ci-artifacts.rust-lang.org/rustc-builds/08affa9a2062264cc5b2b198c45052f92005aaa3/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz); not built yet, try again later.

@oli-obk oli-obk deleted the confusing-stability branch June 20, 2026 07:28
@Kobzol

Kobzol commented Jun 20, 2026

Copy link
Copy Markdown
Member

@rust-timer build 08affa9

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (08affa9): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.6% [0.2%, 1.6%] 10
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 3.8%, secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.8% [3.8%, 3.8%] 1
Regressions ❌
(secondary)		 5.0% [5.0%, 5.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.8% [3.8%, 3.8%] 1

Cycles

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 481.965s -> 481.084s (-0.18%)
Artifact size: 390.67 MiB -> 390.69 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Jun 20, 2026
@JonathanBrouwer

JonathanBrouwer commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

This caused the perf regression in #158145. Is there anything we can do about it?

@mejrs

mejrs commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

We can revert this PR? That said I'm curious why this is a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejrs mejrs mejrs approved these changes

Assignees

@mejrs mejrs

Labels

perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

7 participants

@oli-obk @rustbot @JonathanBrouwer @rust-timer @Kobzol @mejrs @chenyukang