Skip to content

tests: clean up over-constraint on LLVM feature count - #158922

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-clean-up-test-constraint
Jul 8, 2026
Merged

tests: clean up over-constraint on LLVM feature count#158922
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-clean-up-test-constraint

Conversation

@durin42

@durin42 durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Upstream dropped a feature, resulting in the invalid-attribute test failing because it was expecting "and 76 more" but now it's "and 75 more". Adjust the test to do a replacement with a placeholder on that text so the test is less brittle.

Upstream dropped a feature, resulting in the invalid-attribute test
failing because it was expecting "and 76 more" but now it's "and 75
more". Adjust the test to do a replacement with a placeholder on that
text so the test is less brittle.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2026
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@durin42

durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

This is related to #158910, but can land separately.

@durin42

durin42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Jul 7, 2026
@nikic

nikic commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0a81c75 has been approved by nikic

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
…uwer

Rollup of 19 pull requests

Successful merges:

 - #156016 (view-types: store view types in the AST)
 - #157385 (Enable Enzyme on x86_64-apple)
 - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - #158621 (disallow `extern "custom"` on wasm and spirv targets)
 - #158690 (delegation: support mapping of all arguments with `Self` type)
 - #158696 (Rename some `body_id` to `body_def_id`)
 - #158697 (Fixes for QNX SDP 8)
 - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
 - #157801 (Rewrite safety requirements for `Allocator` impls)
 - #158085 (rustdoc: Fix sidebar heading order)
 - #158333 (Fix typetree generation for differentiated functions)
 - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
 - #158791 (Avoid unused braces lint for macro generated arguments)
 - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - #158841 (Avoid final override ICE for RPITIT associated types)
 - #158889 (tests: catch up with LLVM returning f128 on the stack)
 - #158905 (delegation: add constraints to new generic args)
 - #158922 (tests: clean up over-constraint on LLVM feature count)

Failed merges:

 - #158617 (allow mGCA const arguments to fall back to anon consts)
@rust-bors
rust-bors Bot merged commit 7ce91c5 into rust-lang:main Jul 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 8, 2026
rust-timer added a commit that referenced this pull request Jul 8, 2026
Rollup merge of #158922 - durin42:llvm-23-clean-up-test-constraint, r=nikic

tests: clean up over-constraint on LLVM feature count

Upstream dropped a feature, resulting in the invalid-attribute test failing because it was expecting "and 76 more" but now it's "and 75 more". Adjust the test to do a replacement with a placeholder on that text so the test is less brittle.
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer

Rollup of 19 pull requests

Successful merges:

 - rust-lang/rust#156016 (view-types: store view types in the AST)
 - rust-lang/rust#157385 (Enable Enzyme on x86_64-apple)
 - rust-lang/rust#158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
 - rust-lang/rust#158621 (disallow `extern "custom"` on wasm and spirv targets)
 - rust-lang/rust#158690 (delegation: support mapping of all arguments with `Self` type)
 - rust-lang/rust#158696 (Rename some `body_id` to `body_def_id`)
 - rust-lang/rust#158697 (Fixes for QNX SDP 8)
 - rust-lang/rust#158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
 - rust-lang/rust#157801 (Rewrite safety requirements for `Allocator` impls)
 - rust-lang/rust#158085 (rustdoc: Fix sidebar heading order)
 - rust-lang/rust#158333 (Fix typetree generation for differentiated functions)
 - rust-lang/rust#158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
 - rust-lang/rust#158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
 - rust-lang/rust#158791 (Avoid unused braces lint for macro generated arguments)
 - rust-lang/rust#158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
 - rust-lang/rust#158841 (Avoid final override ICE for RPITIT associated types)
 - rust-lang/rust#158889 (tests: catch up with LLVM returning f128 on the stack)
 - rust-lang/rust#158905 (delegation: add constraints to new generic args)
 - rust-lang/rust#158922 (tests: clean up over-constraint on LLVM feature count)

Failed merges:

 - rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants