Tiny readability cleanups for initialization dataflow analyses - #160995
Merged
Conversation
to help readability, regroup all the impls for each analysis together, instead of randomly scattering them in the module.
some analysis impls didn't follow the patterns that all others did: - only constructors need to specify 'a - the functions that don't need 'a are grouped in their own impl
- add some documentation - at use sites, downgrade asserts we don't need, for an argument we don't use. we could also remove the argument, there's a single use site that uses it.
rustbot
added
S-waiting-on-review
Member
|
@bors r+ (sorry about the delay - this is actually very tiny, but looks bigger when reviewing on a phone) |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 20, 2026
Tiny readability cleanups for initialization dataflow analyses While reading over borrowck liveness, I noticed this handful of small things in the dataflow initialization module. They're easier to see per-commit but: - each analysis code was hard to read and locate, as the impls were scattered over the file, so this regroups them - some of these didn't follow the pattern others did - we were asserting things we didn't use, and which were already guaranteed by the function we were calling r? @jackh726
Member
|
@bors try jobs=i686-msvc-1 |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
Tiny readability cleanups for initialization dataflow analyses try-job: i686-msvc-1
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
Rollup of 25 pull requests Successful merges: - #152617 (std: implement `sleep_until` for Fuchsia) - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib) - #160995 (Tiny readability cleanups for initialization dataflow analyses) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`) - #161368 (Double-word align `_Unwind_Exception`) - #161370 (Uplift rustfmt macro formatting fix) - #161378 (`FlowSensitiveAnalysis` cleanups) - #161420 (Bump wasm-component-ld to 0.5.30) - #161429 (Tighten allocator `Send`/`Sync` requirements for `Arc` in preparation for refactor) - #158032 (Offload expose device selection) - #158855 (Add `desktop` method to `CommandExt`) - #160299 (Stabilize `bool::toggle`) - #160842 (Apply `&[T]` visualizer to `*const [T]`, `*mut [T]` and `Box<[T]>`) - #160981 (Partially support building and locating wasm proc-macros) - #161199 (Add regression test for non lifetime binders) - #161212 (rust-installer/install-template.sh: catch cp(1) error when installing…) - #161302 (Add regression test for inconsistent import resolution from issue 147208) - #161329 (Add regression tests for a few fixed issues with E-needs-test) - #161330 (Add regression test for nested RPIT not an iterator ICE) - #161331 (Bitset simplifications) - #161340 (rustdoc: enable scrolling only on table/code) - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`) - #161355 (Add file path to some archive build errors) - #161373 (Allow running EC2 jobs locally)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
Rollup of 25 pull requests Successful merges: - #152617 (std: implement `sleep_until` for Fuchsia) - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib) - #160995 (Tiny readability cleanups for initialization dataflow analyses) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`) - #161368 (Double-word align `_Unwind_Exception`) - #161370 (Uplift rustfmt macro formatting fix) - #161378 (`FlowSensitiveAnalysis` cleanups) - #161420 (Bump wasm-component-ld to 0.5.30) - #161429 (Tighten allocator `Send`/`Sync` requirements for `Arc` in preparation for refactor) - #158032 (Offload expose device selection) - #158855 (Add `desktop` method to `CommandExt`) - #160299 (Stabilize `bool::toggle`) - #160842 (Apply `&[T]` visualizer to `*const [T]`, `*mut [T]` and `Box<[T]>`) - #160981 (Partially support building and locating wasm proc-macros) - #161199 (Add regression test for non lifetime binders) - #161212 (rust-installer/install-template.sh: catch cp(1) error when installing…) - #161302 (Add regression test for inconsistent import resolution from issue 147208) - #161329 (Add regression tests for a few fixed issues with E-needs-test) - #161330 (Add regression test for nested RPIT not an iterator ICE) - #161331 (Bitset simplifications) - #161340 (rustdoc: enable scrolling only on table/code) - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`) - #161355 (Add file path to some archive build errors) - #161373 (Allow running EC2 jobs locally)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
Rollup merge of #160995 - lqd:readabilly, r=jackh726 Tiny readability cleanups for initialization dataflow analyses While reading over borrowck liveness, I noticed this handful of small things in the dataflow initialization module. They're easier to see per-commit but: - each analysis code was hard to read and locate, as the impls were scattered over the file, so this regroups them - some of these didn't follow the pattern others did - we were asserting things we didn't use, and which were already guaranteed by the function we were calling r? @jackh726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading over borrowck liveness, I noticed this handful of small things in the dataflow initialization module.
They're easier to see per-commit but:
r? @jackh726