Repository navigation
Set target-abi module flag for LoongArch targets - #162948
Merged
Merged
Conversation
rustbot
added
A-LLVM
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
heiher
force-pushed
the
loong-emit-target-abi
branch
from
September 18, 2026 08:58
2c72703 to
a03cf23
Compare
nikic
reviewed
Sep 18, 2026
Contributor
There was a problem hiding this comment.
Comment needs an update, as this is no longer RISC-V specific.
Though also the bit below this, because this is not a workaround, setting the target-abi is the correct way to communicate the ABI, and there is nothing to fix here.
heiher
force-pushed
the
loong-emit-target-abi
branch
from
September 19, 2026 08:50
a03cf23 to
ca8ee2f
Compare
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 21, 2026
…uwer Rollup of 5 pull requests Successful merges: - #162948 (Set target-abi module flag for LoongArch targets) - #162600 (Make the last non-breaking box impl generalizations) - #163031 (Use newer `make` version when building GCC) - #163054 (Use verbose suggestion for method written as function) - #163073 (Expand docs on `rustc_abi::Variants`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 21, 2026
Rollup merge of #162948 - heiher:loong-emit-target-abi, r=nikic Set target-abi module flag for LoongArch targets Like the earlier RISC-V fix (#123612), emit the "target-abi" module flag for LoongArch so that LTO correctly picks up the ABI. This follows the recent LLVM change (llvm/llvm-project#223647) that relies on the module flag for proper TargetMachine / data-layout handling during LTO on LoongArch.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 22, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#162948 (Set target-abi module flag for LoongArch targets) - rust-lang/rust#162600 (Make the last non-breaking box impl generalizations) - rust-lang/rust#163031 (Use newer `make` version when building GCC) - rust-lang/rust#163054 (Use verbose suggestion for method written as function) - rust-lang/rust#163073 (Expand docs on `rustc_abi::Variants`)
pull Bot
pushed a commit
to xtqqczze/rust-lang-rustc-dev-guide
that referenced
this pull request
Sep 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#162948 (Set target-abi module flag for LoongArch targets) - rust-lang/rust#162600 (Make the last non-breaking box impl generalizations) - rust-lang/rust#163031 (Use newer `make` version when building GCC) - rust-lang/rust#163054 (Use verbose suggestion for method written as function) - rust-lang/rust#163073 (Expand docs on `rustc_abi::Variants`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the earlier RISC-V fix (#123612), emit the "target-abi" module flag for LoongArch so that LTO correctly picks up the ABI.
This follows the recent LLVM change (llvm/llvm-project#223647) that relies on the module flag for proper TargetMachine / data-layout handling during LTO on LoongArch.