remove old solver use of SolverRelating - #163108
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup Looks like an overeager autocomplete |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 21, 2026
…uwer Rollup of 10 pull requests Successful merges: - #163083 (Remove `G` generic param from `Diag<'_, G>`) - #160679 (Staticlib rename internal symbols: add COFF support) - #160859 (`core::num::f16b` Rust's 16bit Brain Float) - #162007 (Preserve parentheses in raw borrow suggestions) - #162821 (Avoid suggesting closures when captures cross associated item boundaries) - #163057 (Use span context for enclosing item(s) of unmet bound) - #163070 (label the path segment that is not an associated item of the trait) - #163078 ( Add a README in tests/rustdoc-html to explain what each folder content is for) - #163107 (Implement Allocator for Pin unstably) - #163108 (remove old solver use of `SolverRelating`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 21, 2026
…uwer Rollup of 10 pull requests Successful merges: - #163083 (Remove `G` generic param from `Diag<'_, G>`) - #160679 (Staticlib rename internal symbols: add COFF support) - #160859 (`core::num::f16b` Rust's 16bit Brain Float) - #162007 (Preserve parentheses in raw borrow suggestions) - #162821 (Avoid suggesting closures when captures cross associated item boundaries) - #163057 (Use span context for enclosing item(s) of unmet bound) - #163070 (label the path segment that is not an associated item of the trait) - #163078 ( Add a README in tests/rustdoc-html to explain what each folder content is for) - #163107 (Implement Allocator for Pin unstably) - #163108 (remove old solver use of `SolverRelating`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 21, 2026
Rollup merge of #163108 - lcnr:solver-relating-only-next, r=oli-obk remove old solver use of `SolverRelating` cc @BennoLossin @Nadrieril also see the added FIXME `solver_relating::RelateExt` is only intended for use with the new solver. Should hopefully not matter at all in the medium term :> as the old solver is gone r? types
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Sep 21, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#163083 (Remove `G` generic param from `Diag<'_, G>`) - rust-lang/rust#160679 (Staticlib rename internal symbols: add COFF support) - rust-lang/rust#160859 (`core::num::f16b` Rust's 16bit Brain Float) - rust-lang/rust#162007 (Preserve parentheses in raw borrow suggestions) - rust-lang/rust#162821 (Avoid suggesting closures when captures cross associated item boundaries) - rust-lang/rust#163057 (Use span context for enclosing item(s) of unmet bound) - rust-lang/rust#163070 (label the path segment that is not an associated item of the trait) - rust-lang/rust#163078 ( Add a README in tests/rustdoc-html to explain what each folder content is for) - rust-lang/rust#163107 (Implement Allocator for Pin unstably) - rust-lang/rust#163108 (remove old solver use of `SolverRelating`)
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Sep 22, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#163083 (Remove `G` generic param from `Diag<'_, G>`) - rust-lang/rust#160679 (Staticlib rename internal symbols: add COFF support) - rust-lang/rust#160859 (`core::num::f16b` Rust's 16bit Brain Float) - rust-lang/rust#162007 (Preserve parentheses in raw borrow suggestions) - rust-lang/rust#162821 (Avoid suggesting closures when captures cross associated item boundaries) - rust-lang/rust#163057 (Use span context for enclosing item(s) of unmet bound) - rust-lang/rust#163070 (label the path segment that is not an associated item of the trait) - rust-lang/rust#163078 ( Add a README in tests/rustdoc-html to explain what each folder content is for) - rust-lang/rust#163107 (Implement Allocator for Pin unstably) - rust-lang/rust#163108 (remove old solver use of `SolverRelating`)
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 22, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#163083 (Remove `G` generic param from `Diag<'_, G>`) - rust-lang/rust#160679 (Staticlib rename internal symbols: add COFF support) - rust-lang/rust#160859 (`core::num::f16b` Rust's 16bit Brain Float) - rust-lang/rust#162007 (Preserve parentheses in raw borrow suggestions) - rust-lang/rust#162821 (Avoid suggesting closures when captures cross associated item boundaries) - rust-lang/rust#163057 (Use span context for enclosing item(s) of unmet bound) - rust-lang/rust#163070 (label the path segment that is not an associated item of the trait) - rust-lang/rust#163078 ( Add a README in tests/rustdoc-html to explain what each folder content is for) - rust-lang/rust#163107 (Implement Allocator for Pin unstably) - rust-lang/rust#163108 (remove old solver use of `SolverRelating`)
Mark-Simulacrum
added
perf-regression
Member
|
See unrolled perf results in #163111 (comment). Doesn't seem like this PR has much to do with why it would be a regression for include-blob specifically, though. I don't think there's value in following up here; marking as triaged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @BennoLossin @Nadrieril also see the added FIXME
solver_relating::RelateExtis only intended for use with the new solver. Should hopefully not matter at all in the medium term :> as the old solver is goner? types