[rustdoc] Fix invalid jump to def link when `#[rustc_allow_incoherent_impl]` is involved by GuillaumeGomez · Pull Request #163133 · rust-lang/rust

GuillaumeGomez · 2026-09-21T20:06:36Z

Problem here is that the method is not available in the crate where the type is defined. So def_path is actually problematic here as it resolves to the end item, which is not what we want. So instead, I made a simplified version of the rustc_middle::ty::print::pretty::try_print_visible_def_path_recur function.

It's also needed for #162808.

r? @Urgau

Urgau · 2026-09-21T20:51:24Z

+                // `#[rustc_allow_incoherent_impl]` and we need to keep the non-final item path.
+                // Sadly if we use `item_relative_path` which uses `def_path`, it renders the final
+                // item path and not the intermediate one.
+                && let Some(fqp) = transitive_reexport_path(tcx, def_id)


Just asking like this, but can't we always use transitive_reexport_path? maybe with a fallback to item_relative_path.

View changes since the review

We could, but it's likely much slower and also it would not link to the final item anymore if there are transitive crates.

also it would not link to the final item anymore if there are transitive crates.

Do we have a test case for this? If not we should add one.

All the reexport ones I assume?

GuillaumeGomez · 2026-09-22T18:47:06Z

Applied suggestion.

GuillaumeGomez · 2026-09-22T19:21:01Z

Applied it correctly this time. ^^'

rustbot · 2026-09-25T15:13:31Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

GuillaumeGomez · 2026-09-25T15:13:33Z

Fixed merge conflict.

Urgau

r=me with/without the question

View changes since this review

Urgau · 2026-09-25T15:55:03Z

+    }
+
+    let visible_parent = visible_parent_map.get(&def_id).cloned()?;
+    if tcx.is_doc_hidden(visible_parent) {


Do we need/do we wantr to take into account --document-private-items here?

Not too sure about that. I'll add a fixme comment so it's not forgotten and I'll try to find a case where it fails.

… involved

GuillaumeGomez · 2026-09-25T19:40:33Z

@bors r=Urgau

rust-bors · 2026-09-25T19:40:37Z

📌 Commit 21c6277 has been approved by Urgau

It is now in the queue for this repository.

@Urgau

…ent, r=Urgau [rustdoc] Fix invalid jump to def link when `#[rustc_allow_incoherent_impl]` is involved Fixes rust-lang#163112. Problem here is that the method is not available in the crate where the type is defined. So `def_path` is actually problematic here as it resolves to the end item, which is not what we want. So instead, I made a simplified version of the `rustc_middle::ty::print::pretty::try_print_visible_def_path_recur` function. It's also needed for rust-lang#162808. r? @Urgau

…uwer Rollup of 7 pull requests Successful merges: - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - #163133 ([rustdoc] Fix invalid jump to def link when `#[rustc_allow_incoherent_impl]` is involved) - #163215 (Fix suggestion for Option to bool with proper precedence handling) - #163266 (More deferred liveness cleanups) - #163274 (Support -Z merge-functions with gcc and add stack-protector asm tests) - #163312 (Add rustdoc regression test for glob import of a crate that re-exports) - #163332 (Add some docs to `Global`)

Rollup of 13 pull requests Successful merges: - #160695 (Detect bad number of generics caused by bad derive) - #162883 (No longer auto-inline `f16` and `f128` on well-supported platforms) - #163133 ([rustdoc] Fix invalid jump to def link when `#[rustc_allow_incoherent_impl]` is involved) - #163215 (Fix suggestion for Option to bool with proper precedence handling) - #163266 (More deferred liveness cleanups) - #163274 (Support -Z merge-functions with gcc and add stack-protector asm tests) - #163290 (Merge `ForceWarning`/`Allow`/`Expect` into `Warning`) - #163298 (Don't emit sugg for pub-reexport extern std) - #163312 (Add rustdoc regression test for glob import of a crate that re-exports) - #163357 (Borrowck cleanups part trois) - #161710 (Stabilize `mem::conjure_zst`) - #163332 (Add some docs to `Global`) - #163362 (simplify ndk compiler test)

@Urgau

Rollup merge of #163133 - GuillaumeGomez:jump-to-def-incoherent, r=Urgau [rustdoc] Fix invalid jump to def link when `#[rustc_allow_incoherent_impl]` is involved Fixes #163112. Problem here is that the method is not available in the crate where the type is defined. So `def_path` is actually problematic here as it resolves to the end item, which is not what we want. So instead, I made a simplified version of the `rustc_middle::ty::print::pretty::try_print_visible_def_path_recur` function. It's also needed for #162808. r? @Urgau

Rollup of 13 pull requests Successful merges: - rust-lang/rust#160695 (Detect bad number of generics caused by bad derive) - rust-lang/rust#162883 (No longer auto-inline `f16` and `f128` on well-supported platforms) - rust-lang/rust#163133 ([rustdoc] Fix invalid jump to def link when `#[rustc_allow_incoherent_impl]` is involved) - rust-lang/rust#163215 (Fix suggestion for Option to bool with proper precedence handling) - rust-lang/rust#163266 (More deferred liveness cleanups) - rust-lang/rust#163274 (Support -Z merge-functions with gcc and add stack-protector asm tests) - rust-lang/rust#163290 (Merge `ForceWarning`/`Allow`/`Expect` into `Warning`) - rust-lang/rust#163298 (Don't emit sugg for pub-reexport extern std) - rust-lang/rust#163312 (Add rustdoc regression test for glob import of a crate that re-exports) - rust-lang/rust#163357 (Borrowck cleanups part trois) - rust-lang/rust#161710 (Stabilize `mem::conjure_zst`) - rust-lang/rust#163332 (Add some docs to `Global`) - rust-lang/rust#163362 (simplify ndk compiler test)

rustbot assigned Urgau Sep 21, 2026

GuillaumeGomez changed the title ~~Fix invalid jump to def link when #[rustc_allow_incoherent_impl] is involved~~ [rustdoc] Fix invalid jump to def link when #[rustc_allow_incoherent_impl] is involved Sep 21, 2026

GuillaumeGomez force-pushed the jump-to-def-incoherent branch from 480e1c2 to e2275ae Compare September 21, 2026 20:08

Urgau reviewed Sep 21, 2026

View reviewed changes

GuillaumeGomez force-pushed the jump-to-def-incoherent branch from e2275ae to 3f06201 Compare September 22, 2026 18:47

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the jump-to-def-incoherent branch from 3f06201 to 3e0a490 Compare September 22, 2026 18:56

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the jump-to-def-incoherent branch from 3e0a490 to 5f0e4be Compare September 25, 2026 15:13

Urgau approved these changes Sep 25, 2026

View reviewed changes

Fix invalid jump to def link when #[rustc_allow_incoherent_impl] is…

21c6277

… involved

GuillaumeGomez force-pushed the jump-to-def-incoherent branch from 5f0e4be to 21c6277 Compare September 25, 2026 16:16

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2026

JonathanBrouwer mentioned this pull request Sep 25, 2026

Rollup of 7 pull requests #163358

Closed

GuillaumeGomez mentioned this pull request Sep 25, 2026

[rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods #163360

Open

jhpratt mentioned this pull request Sep 26, 2026

Rollup of 13 pull requests #163363

Merged

rust-bors Bot merged commit 061c90a into rust-lang:main Sep 26, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 26, 2026

GuillaumeGomez deleted the jump-to-def-incoherent branch September 26, 2026 16:13

Uh oh!

Conversation

GuillaumeGomez commented Sep 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Urgau Sep 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

Urgau Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

Urgau Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Sep 22, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Sep 22, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 25, 2026

Uh oh!

GuillaumeGomez commented Sep 25, 2026

Uh oh!

Urgau left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Urgau Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Sep 25, 2026

Uh oh!

rust-bors Bot commented Sep 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GuillaumeGomez commented Sep 21, 2026 •

edited by rustbot

Loading

Urgau Sep 21, 2026 •

edited by rustbot

Loading

Urgau left a comment •

edited by rustbot

Loading