Repository navigation
De-duplicate some code in librustdoc/html/render/print_item.rs - #163554
Closed
GuillaumeGomez wants to merge 1 commit into
Closed
GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
GuillaumeGomez
force-pushed
the
cleanup-duplicated-code
branch
from
September 30, 2026 14:14
f5875b2 to
06bfde0
Compare
GuillaumeGomez
force-pushed
the
cleanup-duplicated-code
branch
from
September 30, 2026 14:15
06bfde0 to
df91aae
Compare
Contributor
|
looks like a trivially correct refactor with no significant tradeoff, you can r=me once CI passes. |
Member
|
Lol, this is exactly what my PR also does #163254 (as a drive-by cleanup) which you also reviewed @ binarycat :P |
Member
Author
|
Want me to close this one? I saw it while working on #134868 ^^' |
Contributor
|
I approved #163254, so I'm closing this. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No point in having the same code in 3 different locations when we can have it in one.
r? @lolbinarycat