Repository navigation
Update LLVM submodule to latest release/23.x branch - #163615
Conversation
|
|
I'm gonna beta-nominate this, since I believe that getting this out relatively quickly would be nice: (it's IMO not important enough to warrant a stable point release, so I'm not going to stable nominate) |
This comment was marked as outdated.
This comment was marked as outdated.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
Update LLVM submodule to latest release/23.x branch Updates to rust-lang/llvm-project#200. This includes LLVM 23.1.2, and a bunch of commits from LLVM 23.1.3 (which is yet unreleased). In particular, it includes llvm/llvm-project#224185 (llvm/llvm-project#222721), which should fix #162928. r? nikic @bors rollup=never
|
💔 Test for 80f1681 failed: CI. Failed job:
|
|
I'm unable to retrieve the build log for that job (at least not the part where it actually) fails... Let's see if it can be reproduced. @bors try jobs=dist-aarch64-freebsd |
This comment has been minimized.
This comment has been minimized.
Update LLVM submodule to latest release/23.x branch try-job: dist-aarch64-freebsd
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
Update LLVM submodule to latest release/23.x branch Updates to rust-lang/llvm-project#200. This includes LLVM 23.1.2, and a bunch of commits from LLVM 23.1.3 (which is yet unreleased). In particular, it includes llvm/llvm-project#224185 (llvm/llvm-project#222721), which should fix #162928. r? nikic @bors rollup=never
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #163615. |
|
❗ You can only retry pull requests that are approved and have a previously failed auto build. Hint: If you wanted to retry pull request CI instead, push the latest commit again, or close and then reopen this PR. |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing db8f076 (parent) -> 1d9e680 (this PR) Test differencesShow 52 test diffsStage 1
Stage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1d9e68013afd163e05032b507400ff74d007ed72 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (1d9e680): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -1.8%, secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 492.227s -> 488.976s (-0.66%) |
…SDK (#99) ## What and why On a Mac whose Command Line Tools default to the macOS 27 SDK, nothing in this repository links. `cargo build` fails with `rust-lld: error: could not load TAPI file … libSystem.tbd: malformed file … unknown architecture arm64e.x1`. - **The cause:** the SDK's `.tbd` stubs list a new target, `arm64e.x1`. LLVM's linker rejects a stub it cannot read ([rust-lang/rust#162928](rust-lang/rust#162928)). - **The fix upstream:** in LLVM ([llvm/llvm-project#222721](llvm/llvm-project#222721), backported in [#224185](llvm/llvm-project#224185)). It reaches Rust only in 1.101.0, due on 2026-12-24 ([rust-lang/rust#163615](rust-lang/rust#163615), milestone 1.101.0; [releases.rs](https://releases.rs/)). - **Tested on this Mac:** the `rust-lld` of 1.98.1 (pinned), 1.99.0 and 1.100.0-beta.4 all fail; 1.101.0-nightly links. - **CI:** it passes today only because `macos-latest` is the `macos-26-arm64` image, with Xcode 26. When it moves to the 27 SDK, CI and the macOS release builds fail the same way. `.cargo/config.toml` now leaves macOS to rustc's default, Apple's linker. It ships with Apple's SDK, so it reads it, and a new SDK cannot outrun it the way it outran `rust-lld`. Windows keeps `rust-lld`. The reasons the file gave for `rust-lld` do not hold on macOS: - **Speed:** a release rebuild took 0.55 s with Apple's linker, against 0.53 s. - **"The same linker everywhere":** Linux already used its system linker. The comment now says why each platform links as it does. ## Not in this change - Moving to Rust 1.101 once it is out. With Apple's linker, nothing here waits for it. - Linux and Windows, which are unchanged. ## How it was checked On this Mac, with the default SDK (`xcrun --show-sdk-version`: 27.0), and no `SDKROOT` or linker set in the environment: - From `cargo clean`: `cargo fmt --check`, `cargo clippy --workspace --all-targets --locked -- -D warnings` and `cargo test --workspace --locked` pass (177 tests). - The launcher's tests, the README copy check and the three `scripts/*.test` pass. - A release build, `archgram 0.7.0`, draws `examples/linkshort.json` to the same bytes as archgram 0.7.0 from npm, which CI built with `rust-lld`. The linker changes nothing archgram draws. - CI's macOS jobs run on Xcode 26, where Apple's linker reads that SDK too. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
[beta] backports - Fix ICE for ambiguous candidates on method probing #162904 - Don't imply incorrect things about `Global` in the docs of `System` #163342 - make semicolon_in_expressions_from_non_local_macros not report-in-deps #163364 - Force the correct type variable to never for method resolution on an adjusted never type #163450 - Update LLVM submodule to latest release/23.x branch #163615 - Switch TLS implementation for wasi and bump SDK version to 34 #163809 - use the type name instead of `Self` in constructor paths again #163863 - Re-enable extension of bool return values on x86_64 #163917 - Add `synchronization` import lib to windows-gnullvm dist #163933 - fix(bootstrap/darwin): fix rpath for distributed LLD #163954 r? me
View all comments
Updates to rust-lang/llvm-project#200.
This includes LLVM 23.1.2, and a bunch of commits from LLVM 23.1.3 (which is yet unreleased).
In particular, it includes llvm/llvm-project#224185 (llvm/llvm-project#222721), which should fix #162928.
r? nikic
@bors rollup=never