Skip to content

explicitly handle tests that pass with -Znext-solver - #163655

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:next-solver-pass-tests
Oct 3, 2026
Merged

explicitly handle tests that pass with -Znext-solver#163655
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:next-solver-pass-tests

Conversation

@lcnr

@lcnr lcnr commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

these are all UI tests which pass with the new solver and fail with old. Using explicit revisions here.

Editing some of them to actually test what they should 😁

@rustbot rustbot added F-explicit_tail_calls `#![feature(explicit_tail_calls)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2026
@rustbot

rustbot commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 18 candidates

@lcnr
lcnr force-pushed the next-solver-pass-tests branch from ee37235 to 2f7ad8d Compare October 2, 2026 12:44
lqd
lqd reviewed Oct 2, 2026
View reviewed changes
Comment thread tests/ui/impl-trait/impl-fn-predefined-lifetimes.rs Outdated
lqd
lqd approved these changes Oct 2, 2026
View reviewed changes

@lqd lqd left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me r=me with or without the :imp:

View changes since this review

@rustbot rustbot assigned lqd and unassigned dingxiangfei2009 Oct 2, 2026
@lcnr

lcnr commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors squash msg="explicitly handle tests that pass with -Znext-solver"

@rust-bors

This comment has been minimized.

Sign in to view
@lcnr @lqd
explicitly handle tests that pass with -Znext-solver
df07926 
Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
@rust-bors

rust-bors Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into df07926.

@rust-bors
rust-bors Bot force-pushed the next-solver-pass-tests branch from 2c2a2bb to df07926 Compare October 2, 2026 15:42
@lcnr

lcnr commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=lqd rollup=iffy

@rust-bors

rust-bors Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit df07926 has been tentatively approved by lqd

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2026
@lcnr

lcnr commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

only iffy because it affects a lot of tests

@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 2, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 2, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
1199dc5 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #163655 (explicitly handle tests that pass with -Znext-solver)
 - #159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - #163572 (Update the minimum external LLVM to 22)
 - #129822 (Docs - type guarantees update)
 - #157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - #162332 (preserve overflow in builtin Field candidates)
 - #163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - #163638 (avoid trivial `fn map_bound` validations)
 - #163660 (yeet compare-mode-coherence)
rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
b6e4b5c 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #163655 (explicitly handle tests that pass with -Znext-solver)
 - #159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - #163572 (Update the minimum external LLVM to 22)
 - #129822 (Docs - type guarantees update)
 - #157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - #162332 (preserve overflow in builtin Field candidates)
 - #163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - #163638 (avoid trivial `fn map_bound` validations)
 - #163660 (yeet compare-mode-coherence)
@rust-bors
rust-bors Bot merged commit 220201e into rust-lang:main Oct 3, 2026
14 checks passed
rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026
@bors
Unrolled build for #163655 in rollup 163680
b6f3bc2 
Rollup merge of #163655 - lcnr:next-solver-pass-tests, r=lqd

explicitly handle tests that pass with -Znext-solver

these are all UI tests which pass with the new solver and fail with old. Using explicit revisions here.

Editing some of them to actually test what they should 😁
@rustbot rustbot added this to the 1.101.0 milestone Oct 3, 2026
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Draft
github-actions Bot pushed a commit to rust-lang/stdarch that referenced this pull request Oct 5, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
4d6cce7 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#163655 (explicitly handle tests that pass with -Znext-solver)
 - rust-lang/rust#159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
 - rust-lang/rust#129822 (Docs - type guarantees update)
 - rust-lang/rust#157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - rust-lang/rust#162332 (preserve overflow in builtin Field candidates)
 - rust-lang/rust#163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - rust-lang/rust#163638 (avoid trivial `fn map_bound` validations)
 - rust-lang/rust#163660 (yeet compare-mode-coherence)
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Oct 5, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
27136e9 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#163655 (explicitly handle tests that pass with -Znext-solver)
 - rust-lang/rust#159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
 - rust-lang/rust#129822 (Docs - type guarantees update)
 - rust-lang/rust#157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - rust-lang/rust#162332 (preserve overflow in builtin Field candidates)
 - rust-lang/rust#163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - rust-lang/rust#163638 (avoid trivial `fn map_bound` validations)
 - rust-lang/rust#163660 (yeet compare-mode-coherence)
programskillforverification pushed a commit to programskillforverification/miri that referenced this pull request Oct 5, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
189e7b4 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#163655 (explicitly handle tests that pass with -Znext-solver)
 - rust-lang/rust#159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
 - rust-lang/rust#129822 (Docs - type guarantees update)
 - rust-lang/rust#157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - rust-lang/rust#162332 (preserve overflow in builtin Field candidates)
 - rust-lang/rust#163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - rust-lang/rust#163638 (avoid trivial `fn map_bound` validations)
 - rust-lang/rust#163660 (yeet compare-mode-coherence)
AzureXuanVerse pushed a commit to AzureXuanVerse/rustfmt that referenced this pull request Oct 7, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
fd226ad 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#163655 (explicitly handle tests that pass with -Znext-solver)
 - rust-lang/rust#159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
 - rust-lang/rust#129822 (Docs - type guarantees update)
 - rust-lang/rust#157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - rust-lang/rust#162332 (preserve overflow in builtin Field candidates)
 - rust-lang/rust#163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - rust-lang/rust#163638 (avoid trivial `fn map_bound` validations)
 - rust-lang/rust#163660 (yeet compare-mode-coherence)
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163680 - JonathanBrouwer:rollup-L685mEZ, r=JonathanBro…
2021724 
…uwer

Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#163655 (explicitly handle tests that pass with -Znext-solver)
 - rust-lang/rust#159924 (Send -fno-lto when linker plugin LTO is not requested to avoid having GCC do LTO when using rustc_codegen_gcc)
 - rust-lang/rust#163572 (Update the minimum external LLVM to 22)
 - rust-lang/rust#129822 (Docs - type guarantees update)
 - rust-lang/rust#157973 (Distinguish `repr(C)` ZSTs from others in ABI compatibility rules)
 - rust-lang/rust#162332 (preserve overflow in builtin Field candidates)
 - rust-lang/rust#163574 (intrinsics: Rename `abort` to `abort_immediate`)
 - rust-lang/rust#163638 (avoid trivial `fn map_bound` validations)
 - rust-lang/rust#163660 (yeet compare-mode-coherence)
@lcnr lcnr mentioned this pull request Oct 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd approved these changes

Assignees

@lqd lqd

Labels

F-explicit_tail_calls `#![feature(explicit_tail_calls)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lcnr @rustbot @lqd @dingxiangfei2009