Repository navigation
refactor: migrate to LLVM-C's LLVMGetOrInsertFunction - #163690
Merged
rust-bors[bot] merged 1 commit intoOct 3, 2026
Merged
Conversation
rustbot
added
A-LLVM
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Thanks! r?me @bors r+ rollup |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
…uwer Rollup of 8 pull requests Successful merges: - #163645 (add `ignore-compare-mode-next-solver` to all next-solver tests) - #163663 (reflection: fix ICE when TypeId::info called on ADT) - #163454 (Improve suggestion for lifetime preceding type in generics) - #163561 (tests: accept noundef in a couple more places) - #163633 (core: io: clean `unused_variables` lint under `no_io_statics`) - #163681 (Make the tracking issue template better suited for experiments) - #163685 (Avoid long iterator chain in all_rust_features) - #163690 (refactor: migrate to LLVM-C's `LLVMGetOrInsertFunction`) Failed merges: - #161491 (Rip out old solver coherence)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
Rollup merge of #163690 - AMS21:refactor_get_or_insert_function, r=hanna-kruppe refactor: migrate to LLVM-C's `LLVMGetOrInsertFunction` As the removed fixme already states we don't need to maintain our own wrapper anymore as `LLVMGetOrInsertFunction` is part of LLVM since version 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the removed fixme already states we don't need to maintain our own wrapper anymore as
LLVMGetOrInsertFunctionis part of LLVM since version 22.