Skip to content

When documenting without a specified --edition, emit a message - #163795

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:note-default-edition
Oct 6, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:note-default-edition

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Follow-up of #158102.

cc @estebank
r? @notriddle

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 5, 2026
@notriddle

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d9d979c has been approved by notriddle

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #160915 ([rustdoc] Fix how `Deref` items is handled.)
 - #163267 (fix `VisibleForLeakCheck` in `RegionOutlives` fast path)
 - #163673 (Move #[doc(inline)] and #[doc(no_inline)] validation into rustc_attr_parsing)
 - #163795 (When documenting without a specified `--edition`, emit a message)
 - #163814 (Add some comments and docs related to `AllocatorNightly`)
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #160915 ([rustdoc] Fix how `Deref` items is handled.)
 - #163267 (fix `VisibleForLeakCheck` in `RegionOutlives` fast path)
 - #163673 (Move #[doc(inline)] and #[doc(no_inline)] validation into rustc_attr_parsing)
 - #163795 (When documenting without a specified `--edition`, emit a message)
 - #163814 (Add some comments and docs related to `AllocatorNightly`)
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #160915 ([rustdoc] Fix how `Deref` items is handled.)
 - #163267 (fix `VisibleForLeakCheck` in `RegionOutlives` fast path)
 - #163673 (Move #[doc(inline)] and #[doc(no_inline)] validation into rustc_attr_parsing)
 - #163795 (When documenting without a specified `--edition`, emit a message)
 - #163814 (Add some comments and docs related to `AllocatorNightly`)
@rust-bors
rust-bors Bot merged commit 46ff523 into rust-lang:main Oct 6, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 6, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 6, 2026
Rollup merge of #163795 - GuillaumeGomez:note-default-edition, r=notriddle

When documenting without a specified `--edition`, emit a message

Follow-up of #158102.

cc @estebank
r? @notriddle
@GuillaumeGomez
GuillaumeGomez deleted the note-default-edition branch October 6, 2026 09:58
weihanglo added a commit to weihanglo/cargo that referenced this pull request Oct 7, 2026
Our doc-merge rustdoc invocation didn't pass `--edition`
hence affected by rust-lang/rust#163795
weihanglo pushed a commit to weihanglo/cargo that referenced this pull request Oct 7, 2026
Our doc-merge rustdoc invocation didn't pass `--edition`
hence affected by rust-lang/rust#163795

See
https://github.com/rust-lang/cargo/actions/runs/37574863868/job/112641362620

BTW, we probably want to pass the workspace denominator `edition`,
though let us unblock the CI first.

🤖 LLM disclosure: snapshot regenerations (which only add
`--edition=2015`)
weihanglo added a commit to weihanglo/cargo that referenced this pull request Oct 14, 2026
Our doc-merge rustdoc invocation didn't pass `--edition`
hence affected by rust-lang/rust#163795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants