Unignore tests in stage1

[tamird]

We don't have any pending snapshot-requiring changes.

Works toward #3965.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

Just to confirm, have you run all these tests in stage1? Plugins fundamentally don't work in stage1, so many of these I believe are intentional.

[tamird]

I haven't, but I'll do that now!

[tamird]

Hm. make check-stage1 passed locally.

[alexcrichton]

Ah right, it is possible for these tests to work at stage1 (if codegen is similar enough in stage0 and stage1), but it's not guaranteed. For example if codegen changes after stage0 then plugins will be broken.

[tamird]

So: wat do?

[tamird]

[alexcrichton]

I think that this should back out the removal of // ignore-stage from all *-fulldeps tests, but all changes to src/test/{auxiliary,run-pass} look good to me!

[tamird]

I think it's probably OK to unignore compilefail-fulldeps; do you agree?

[alexcrichton]

I think it kinda depends on the test. Anything which expects #![plugin] to succeed (e.g. have the dlopen be a success) must be ignored in stage1, but some of these tests are expecting a compiler error before we hit that point so they can be un-ignored yeah.

[tamird]

@alexcrichton is there a change I can make locally to induce the condition that would break these tests in stage1? feels a bit like a guessing game otherwise.

[alexcrichton]

I think if you change the symbol hashing function it'll cause the symbols to be totally different at stage1 than they were at stage0, so you can try just adding symbol_hasher.input_str("foo") somewhere in there perhaps? I haven't exactly tested out this theory though, so it also may not work :(

[tamird]

Your suggestion worked! I tested these locally and they passed (with the hashing change) so this should be good to merge. Thanks for your help @alexcrichton.

[alexcrichton]

@bors: r+ f548a05

Nice! Thanks!

[alexcrichton]

@bors: rollup

[bors]

⌛ Testing commit f548a05 with merge b1bd3a3...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt