Rollup of 10 pull requests - #25421
Merged
Merged
Conversation
steveklabnik
commented
May 15, 2015
steveklabnik
commented
Contributor
- Successful merges: trpl-docs: Specify correct type of variable binding #25404, Another thread->task fix. #25405, trpl: punctuation fix #25407, Fixing typos in Rust Book: The Stack and Heap section #25408, trpl: fix some broken internal links #25410, Add #[inline] to Borrow<str>::borrow for String. #25412, TRPL: Fix Internal Link #25413, s/Iterater/Iterator/ #25414, trpl: Fix missing internal links #25418, Remove an almost-duplicated sentence from the enum page in the book #25420
- Failed merges:
…rence to d, and so it should contain the memory location of d. I also fixed the incorrectly formatted tables.
This PR fixes a comment in the `while Loops` section of the Rust book with the correct type of a variable binding.
…-typo, r=steveklabnik I fixed the typo of the value of e in the memory tables. It is a reference to d, and so it should contain the memory location of d. I also fixed the incorrectly formatted tables so they display properly in html pages.
Every time I profile my code I find something new to add #[inline] to. (:
It seems to refer to something that used to exist, but got moved, and then not everything got cleaned up.
Contributor
Author
|
@bors: r+ p=1 |
Collaborator
|
📌 Commit 6df13d4 has been approved by |
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.