Rename ExprKind::Vec to Array in HIR and HAIR.#39090
Merged
Merged
Conversation
This is a clearer name since they represent [a, b, c] array literals.
Member
|
Oh its only HIR, nvmd. |
Contributor
Author
|
Either way, it's not for no reason. We had a previous related PR but I guess it didn't do the entire job. |
eddyb
approved these changes
Jan 16, 2017
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit a9f8f98 has been approved by |
Collaborator
|
⌛ Testing commit a9f8f98 with merge 24235f2... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
@bors retry |
Collaborator
|
⌛ Testing commit a9f8f98 with merge 94c0c6b... |
Collaborator
|
💔 Test failed - status-travis |
Member
|
… On Mon, Jan 16, 2017 at 7:56 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/192398321>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39090 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95JnUsHb3ueOpAudYKBNKFnkSAH9qks5rS5MqgaJpZM4LkTPr>
.
|
Collaborator
bors
added a commit
that referenced
this pull request
Jan 17, 2017
Rename ExprKind::Vec to Array in HIR and HAIR. This is a clearer name since they represent `[a, b, c]` array literals. r? @eddyb
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clearer name since they represent
[a, b, c]array literals.r? @eddyb