The Magenta kernel is now called Zircon. by pylaligand · Pull Request #44612 · rust-lang/rust

pylaligand · 2017-09-15T19:44:33Z

No description provided.

rust-highfive · 2017-09-15T19:44:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

pylaligand · 2017-09-15T19:51:10Z

Hi there! I hope I caught all the instances, but haven't been able to run tests yet. Any guidance on how to produce appropriate test coverage would be much appreciated.

mattico · 2017-09-15T20:08:17Z

You can set ALLOW_PR=1 in

rust/.travis.yml

Line 98 in fd4bef5

- env: IMAGE=dist-fuchsia DEPLOY=1

To let you test this on travis before r+

dtolnay · 2017-09-17T04:54:36Z

Tier 2 platform + senior Google employee working on platform + everything in this PR only affects that platform = do what you want, I guess. 😜 r=me after removing ALLOW_PR=1.

bors · 2017-09-17T05:24:56Z

☔ The latest upstream changes (presumably #44634) made this pull request unmergeable. Please resolve the merge conflicts.

pylaligand · 2017-09-18T21:23:44Z

Rebased, but it looks like I picked up some submodules changes. Not sure what to make of these.

pylaligand · 2017-09-18T22:47:13Z

I think I fixed the submodules issue.

pylaligand · 2017-09-18T23:18:14Z

@dtolnay, could you approve this change? I removed the Travis testing bit and rebased.

dtolnay · 2017-09-18T23:36:21Z

@bors r+

bors · 2017-09-18T23:36:22Z

📌 Commit 9f0cd9e has been approved by dtolnay

pylaligand · 2017-09-19T00:22:56Z

Thanks for the approval @dtolnay. What's the next step, will the bot check the change in? Sorry for pressing, but this is blocking some of our work over in Fuchsialand.

dtolnay · 2017-09-19T00:29:10Z

Yep, the bot will merge as soon as the build passes against the merge commit. That ensures the master branch is always a commit that has passed all CI (the "not rocket science" approach to CI). I'm not really familiar with this UI but here is the current queue: https://buildbot2.rust-lang.org/homu/queue/rust

bors · 2017-09-19T12:57:01Z

⌛ Testing commit 9f0cd9ea03f26d98c452694a6c04a8c6b6587581 with merge 62b24094ffa0320bedd21ab33f9d0bb5da853b20...

bors · 2017-09-19T13:06:28Z

💔 Test failed - status-travis

kennytm · 2017-09-19T15:01:26Z

The download-toolchain script failed on Fuchsia. There is no unzip command?

[00:05:25] + ./zircon/scripts/download-toolchain
[00:05:25] Downloading https://fuchsia-build.storage.googleapis.com/magenta/toolchain/x86_64-elf/Linux-x86_64/509cd48809f5252ffc8ef0c72dbf208151750f66
######################################################################## 100.0%
[00:05:25] Unpacking /tmp/zircon/prebuilt/downloads/x86_64-elf-Linux-x86_64.tar.bz2
[00:05:32] Downloading https://fuchsia-build.storage.googleapis.com/magenta/toolchain/aarch64-elf/Linux-x86_64/509cd48809f5252ffc8ef0c72dbf208151750f66
######################################################################## 100.0%
[00:05:32] Unpacking /tmp/zircon/prebuilt/downloads/aarch64-elf-Linux-x86_64.tar.bz2
[00:05:39] Downloading https://storage.googleapis.com/fuchsia/clang/linux-amd64/86d57720455e2d6aff2b48f9cea3ef77ab2af06a
######################################################################## 100.0%
[00:05:40] Unpacking /tmp/zircon/prebuilt/downloads/clang+llvm-x86_64-linux.zip
[00:05:40] ./zircon/scripts/download-toolchain: line 121: unzip: command not found
[00:05:40] The command '/bin/sh -c /tmp/build-toolchain.sh' returned a non-zero code: 127

pylaligand · 2017-09-19T16:41:54Z

@petrhosek see error above.

pylaligand · 2017-09-19T18:15:16Z

Does this need another approval or will the bot pick it up again?

kennytm · 2017-09-19T18:17:15Z

Yes it needs another approval.

r? @dtolnay

dtolnay · 2017-09-19T18:17:49Z

@bors r+

bors · 2017-09-19T18:17:50Z

📌 Commit 23ef8fd has been approved by dtolnay

dtolnay · 2017-09-19T19:41:07Z

@bors r+

bors · 2017-09-19T19:41:08Z

📌 Commit fbcb0a5 has been approved by dtolnay

raggi · 2017-09-20T18:59:52Z

@dtolnay thanks for plugging away with us. I just pushed a rebase and and update of liblibc, which should fix the linker failure. When I tested this locally, it looks like liblibc 0.2.31 has dependencies on other submodules that would need to be updated, but I'm not sure which ones. Would appreciate seeing if it builds in the bots, as my local build may be different.

This toolchain is already used to build Zircon itself and is the official Clang toolchain used by all Fuchsia developers.

This appears to be needed by the Rust build.

raggi · 2017-09-24T20:57:33Z

Rebased and fixed up, I think those changes might even fix our build issue. Ever hopeful.

dtolnay · 2017-09-24T21:01:39Z

@bors r+

bors · 2017-09-24T21:01:39Z

📌 Commit c481f85 has been approved by dtolnay

dtolnay · 2017-09-24T21:05:12Z

If you need to push any more changes and the new changes only affect the fuchsia target, leave a comment @bors r=dtolnay and the bot will build it without waiting for me to review.

bors · 2017-09-24T21:05:12Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: put empty generic lists behind a pointer #44758

bors · 2017-09-24T21:05:13Z

📌 Commit c481f85 has been approved by `dtolnay``

bors · 2017-09-25T00:38:16Z

⌛ Testing commit c481f85 with merge b2968acc726d5d33ab4ad4a768d16bfd7eee94a4...

bors · 2017-09-25T00:52:12Z

💔 Test failed - status-travis

* Adjust bootstrap to provide useful output on failure * Add missing package dependencies in the build environment * Fix permission bits on prebuilt toolchain files

raggi · 2017-09-25T04:44:38Z

@bors r=dtolnay

bors · 2017-09-25T04:44:38Z

@raggi: 🔑 Insufficient privileges: Not in reviewers

dtolnay · 2017-09-25T04:47:35Z

Oh I didn't know about that. I will try to find out whether there is a way to delegate review permission.

@bors r+

bors · 2017-09-25T04:47:36Z

📌 Commit a3aef1a has been approved by dtolnay

alexcrichton · 2017-09-25T04:47:38Z

@bors: r+

bors · 2017-09-25T04:47:38Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Move effect-checking to MIR #44700

bors · 2017-09-25T04:47:38Z

📌 Commit a3aef1a has been approved by alexcrichton

alexcrichton · 2017-09-25T04:48:10Z

@bors: delegate=raggi

bors · 2017-09-25T04:48:11Z

✌️ @raggi can now approve this pull request

bors · 2017-09-25T05:05:20Z

⌛ Testing commit a3aef1a with merge cd93969...

The Magenta kernel is now called Zircon.

bors · 2017-09-25T09:01:49Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cd93969 to master...

raggi · 2017-09-25T18:14:22Z

Thanks again folks for all your patience and assistance.

rust-highfive assigned dtolnay Sep 15, 2017

carols10cents added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 18, 2017

pylaligand force-pushed the magenta-to-zircon branch from b66611b to e9d7c04 Compare September 18, 2017 21:21

arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2017

raggi force-pushed the magenta-to-zircon branch from fbcb0a5 to 88d689a Compare September 20, 2017 18:57

petrhosek and others added 3 commits September 24, 2017 13:55

Use Zircon's Clang rather than building our own

1fdbfa9

This toolchain is already used to build Zircon itself and is the official Clang toolchain used by all Fuchsia developers.

Re-add CMake package

992e94a

This appears to be needed by the Rust build.

ensure that prebuilt toolchain binaries are +x

c481f85

raggi force-pushed the magenta-to-zircon branch from 77475ef to c481f85 Compare September 24, 2017 20:56

LP_CLONE_FDIO_ROOT is now LP_CLONE_FDIO_NAMESPACE

d7a17fb

Fix fuchsia toolchain prebuild setup

a3aef1a

* Adjust bootstrap to provide useful output on failure * Add missing package dependencies in the build environment * Fix permission bits on prebuilt toolchain files

bors added a commit that referenced this pull request Sep 25, 2017

Auto merge of #44612 - pylaligand:magenta-to-zircon, r=alexcrichton

cd93969

The Magenta kernel is now called Zircon.

bors merged commit a3aef1a into rust-lang:master Sep 25, 2017

kennytm mentioned this pull request Oct 7, 2017

Beta 20170928 #44908

Merged

Uh oh!

Uh oh!

Conversation

pylaligand commented Sep 15, 2017

Uh oh!

rust-highfive commented Sep 15, 2017

Uh oh!

pylaligand commented Sep 15, 2017

Uh oh!

mattico commented Sep 15, 2017

Uh oh!

dtolnay commented Sep 17, 2017

Uh oh!

bors commented Sep 17, 2017

Uh oh!

pylaligand commented Sep 18, 2017

Uh oh!

pylaligand commented Sep 18, 2017

Uh oh!

pylaligand commented Sep 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay commented Sep 18, 2017

Uh oh!

bors commented Sep 18, 2017

Uh oh!

pylaligand commented Sep 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay commented Sep 19, 2017

Uh oh!

bors commented Sep 19, 2017

Uh oh!

bors commented Sep 19, 2017

Uh oh!

kennytm commented Sep 19, 2017

Uh oh!

pylaligand commented Sep 19, 2017

Uh oh!

pylaligand commented Sep 19, 2017

Uh oh!

kennytm commented Sep 19, 2017

Uh oh!

dtolnay commented Sep 19, 2017

Uh oh!

bors commented Sep 19, 2017

Uh oh!

dtolnay commented Sep 19, 2017

Uh oh!

bors commented Sep 19, 2017

Uh oh!

raggi commented Sep 20, 2017

Uh oh!

raggi commented Sep 24, 2017

Uh oh!

dtolnay commented Sep 24, 2017

Uh oh!

bors commented Sep 24, 2017

Uh oh!

dtolnay commented Sep 24, 2017

Uh oh!

bors commented Sep 24, 2017

Uh oh!

bors commented Sep 24, 2017

Uh oh!

bors commented Sep 25, 2017

Uh oh!

bors commented Sep 25, 2017

Uh oh!

raggi commented Sep 25, 2017

Uh oh!

bors commented Sep 25, 2017

Uh oh!

dtolnay commented Sep 25, 2017

Uh oh!

bors commented Sep 25, 2017

Uh oh!

alexcrichton commented Sep 25, 2017

Uh oh!

bors commented Sep 25, 2017

pylaligand commented Sep 18, 2017 •

edited

Loading

pylaligand commented Sep 19, 2017 •

edited

Loading