librustc: Mark all type implementations public. rs=impl-publicity - #5136
Closed
pcwalton wants to merge 3 commits into
Closed
librustc: Mark all type implementations public. rs=impl-publicity #5136pcwalton wants to merge 3 commits into
pcwalton wants to merge 3 commits into
Conversation
bors
added a commit
that referenced
this pull request
Feb 27, 2013
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 27, 2026
Automatic Rustup
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
Various whitespace-related changes did not so far respect `--file-lines`, see also [#5136](tests/target/issue-5136-4.rs). This PR fixes this in all of the cases reported in #5136: * Newlines at the beginning of the file * Spaces at the beginning of the file * Missing newline at the end of the file * Space after a doc comment * Space before a comment in the last line of the file (without trailing newline) The PR includes tests that fail without the fixes.
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
5136: Split namespace maps in `ItemScope` r=jonas-schievink a=jonas-schievink Reduces memory usage of the CrateDefMap query by ~130 MB (50%) on r-a. I was also looking into handling glob imports more efficiently (storing scope chains instead of always duplicating everything into the glob-importing module's scope), but it seems that this already gives the most significant wins. Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.